clocksource: Replace vread with generic arch data
The vread field was bloating struct clocksource everywhere except x86_64, and I want to change the way this works on x86_64, so let's split it out into per-arch data. Cc: x86@kernel.org Cc: Clemens Ladisch <clemens@ladisch.de> Cc: linux-ia64@vger.kernel.org Cc: Tony Luck <tony.luck@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: John Stultz <johnstul@us.ibm.com> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andy Lutomirski <luto@mit.edu> Link: http://lkml.kernel.org/r/3ae5ec76a168eaaae63f08a2a1060b91aa0b7759.1310563276.git.luto@mit.edu Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
This commit is contained in:
parent
7f79ad15f3
commit
433bd805e5
6 changed files with 31 additions and 5 deletions
16
arch/x86/include/asm/clocksource.h
Normal file
16
arch/x86/include/asm/clocksource.h
Normal file
|
@ -0,0 +1,16 @@
|
|||
/* x86-specific clocksource additions */
|
||||
|
||||
#ifndef _ASM_X86_CLOCKSOURCE_H
|
||||
#define _ASM_X86_CLOCKSOURCE_H
|
||||
|
||||
#ifdef CONFIG_X86_64
|
||||
|
||||
#define __ARCH_HAS_CLOCKSOURCE_DATA
|
||||
|
||||
struct arch_clocksource_data {
|
||||
cycle_t (*vread)(void);
|
||||
};
|
||||
|
||||
#endif /* CONFIG_X86_64 */
|
||||
|
||||
#endif /* _ASM_X86_CLOCKSOURCE_H */
|
|
@ -753,7 +753,7 @@ static struct clocksource clocksource_hpet = {
|
|||
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
|
||||
.resume = hpet_resume_counter,
|
||||
#ifdef CONFIG_X86_64
|
||||
.vread = vread_hpet,
|
||||
.archdata = { .vread = vread_hpet },
|
||||
#endif
|
||||
};
|
||||
|
||||
|
|
|
@ -777,7 +777,7 @@ static struct clocksource clocksource_tsc = {
|
|||
.flags = CLOCK_SOURCE_IS_CONTINUOUS |
|
||||
CLOCK_SOURCE_MUST_VERIFY,
|
||||
#ifdef CONFIG_X86_64
|
||||
.vread = vread_tsc,
|
||||
.archdata = { .vread = vread_tsc },
|
||||
#endif
|
||||
};
|
||||
|
||||
|
|
|
@ -74,7 +74,7 @@ void update_vsyscall(struct timespec *wall_time, struct timespec *wtm,
|
|||
write_seqlock_irqsave(&vsyscall_gtod_data.lock, flags);
|
||||
|
||||
/* copy vsyscall data */
|
||||
vsyscall_gtod_data.clock.vread = clock->vread;
|
||||
vsyscall_gtod_data.clock.vread = clock->archdata.vread;
|
||||
vsyscall_gtod_data.clock.cycle_last = clock->cycle_last;
|
||||
vsyscall_gtod_data.clock.mask = clock->mask;
|
||||
vsyscall_gtod_data.clock.mult = mult;
|
||||
|
|
4
include/asm-generic/clocksource.h
Normal file
4
include/asm-generic/clocksource.h
Normal file
|
@ -0,0 +1,4 @@
|
|||
/*
|
||||
* Architectures should override this file to add private userspace
|
||||
* clock magic if needed.
|
||||
*/
|
|
@ -22,6 +22,8 @@
|
|||
typedef u64 cycle_t;
|
||||
struct clocksource;
|
||||
|
||||
#include <asm/clocksource.h>
|
||||
|
||||
/**
|
||||
* struct cyclecounter - hardware abstraction for a free running counter
|
||||
* Provides completely state-free accessors to the underlying hardware.
|
||||
|
@ -153,7 +155,7 @@ extern u64 timecounter_cyc2time(struct timecounter *tc,
|
|||
* @shift: cycle to nanosecond divisor (power of two)
|
||||
* @max_idle_ns: max idle time permitted by the clocksource (nsecs)
|
||||
* @flags: flags describing special properties
|
||||
* @vread: vsyscall based read
|
||||
* @archdata: arch-specific data
|
||||
* @suspend: suspend function for the clocksource, if necessary
|
||||
* @resume: resume function for the clocksource, if necessary
|
||||
*/
|
||||
|
@ -175,10 +177,14 @@ struct clocksource {
|
|||
#else
|
||||
#define CLKSRC_FSYS_MMIO_SET(mmio, addr) do { } while (0)
|
||||
#endif
|
||||
|
||||
#ifdef __ARCH_HAS_CLOCKSOURCE_DATA
|
||||
struct arch_clocksource_data archdata;
|
||||
#endif
|
||||
|
||||
const char *name;
|
||||
struct list_head list;
|
||||
int rating;
|
||||
cycle_t (*vread)(void);
|
||||
int (*enable)(struct clocksource *cs);
|
||||
void (*disable)(struct clocksource *cs);
|
||||
unsigned long flags;
|
||||
|
|
Loading…
Reference in a new issue