bsr: avoid format string leaking into device name

This makes sure a format string cannot accidentally leak into a device name.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kees Cook 2014-06-10 10:51:08 -07:00 committed by Greg Kroah-Hartman
parent 7b88344631
commit 4171ee9e3c

View file

@ -259,7 +259,7 @@ static int bsr_add_node(struct device_node *bn)
} }
cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev, cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
cur, cur->bsr_name); cur, "%s", cur->bsr_name);
if (IS_ERR(cur->bsr_device)) { if (IS_ERR(cur->bsr_device)) {
printk(KERN_ERR "device_create failed for %s\n", printk(KERN_ERR "device_create failed for %s\n",
cur->bsr_name); cur->bsr_name);