Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

dmaengine: imx-sdma: sdma_get_firmware does not need to copy fw_name

Browse source 
It does not need to allocate space and copy fw_name in function
sdma_get_firmware().

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Shawn Guo 2011-07-15 17:25:28 +08:00
parent 62550cd7c0
commit 40ad5b3791
1 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/dma/imx-sdma.c
View file

@ -1126,22 +1126,14 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma,
const char *fw_name) const char *fw_name)
{ {
const struct firmware *fw; const struct firmware *fw;
char *fwname;
const struct sdma_firmware_header *header; const struct sdma_firmware_header *header;
int ret; int ret;
const struct sdma_script_start_addrs *addr; const struct sdma_script_start_addrs *addr;
unsigned short *ram_code; unsigned short *ram_code;
fwname = kasprintf(GFP_KERNEL, "%s", fw_name); ret = request_firmware(&fw, fw_name, sdma->dev);
if (!fwname) if (ret)
return -ENOMEM;
ret = request_firmware(&fw, fwname, sdma->dev);
if (ret) {
kfree(fwname);
return ret; return ret;
}
kfree(fwname);
if (fw->size < sizeof(*header)) if (fw->size < sizeof(*header))
goto err_firmware; goto err_firmware;