Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

PM: Fix suspend_console and resume_console to use only one semaphore

Browse source 
This fixes a race where a thread acquires the console while the
console is suspended, and the console is resumed before this
thread releases it. In this case, the secondary console
semaphore would be left locked, and the primary semaphore would
be released twice. This in turn would cause the console switch
on suspend or resume to hang forever.

Note that suspend_console does not actually lock the console
for clients that use acquire_console_sem, it only locks it for
clients that use try_acquire_console_sem. If we change
suspend_console to fully lock the console, then the kernel
may deadlock on suspend. One client of try_acquire_console_sem
is acquire_console_semaphore_for_printk, which uses it to
prevent printk from using the console while it is suspended.

Signed-off-by: Arve Hjønnevåg <arve@android.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>
Cc: Greg KH <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Arve Hjønnevåg 2009-02-14 02:07:24 +01:00 committed by Linus Torvalds
parent b090f9fa53
commit 403f307576
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
kernel/printk.c
View file

@ -73,7 +73,6 @@ EXPORT_SYMBOL(oops_in_progress);
* driver system. * driver system.
*/ */
static DECLARE_MUTEX(console_sem); static DECLARE_MUTEX(console_sem);
static DECLARE_MUTEX(secondary_console_sem);
struct console *console_drivers; struct console *console_drivers;
EXPORT_SYMBOL_GPL(console_drivers); EXPORT_SYMBOL_GPL(console_drivers);
@ -891,12 +890,14 @@ void suspend_console(void)
printk("Suspending console(s) (use no_console_suspend to debug)\n"); printk("Suspending console(s) (use no_console_suspend to debug)\n");
acquire_console_sem(); acquire_console_sem();
console_suspended = 1; console_suspended = 1;
up(&console_sem);
} }
void resume_console(void) void resume_console(void)
{ {
if (!console_suspend_enabled) if (!console_suspend_enabled)
return; return;
down(&console_sem);
console_suspended = 0; console_suspended = 0;
release_console_sem(); release_console_sem();
} }
@ -912,11 +913,9 @@ void resume_console(void)
void acquire_console_sem(void) void acquire_console_sem(void)
{ {
BUG_ON(in_interrupt()); BUG_ON(in_interrupt());
if (console_suspended) {
down(&secondary_console_sem);
return;
}
down(&console_sem); down(&console_sem);
if (console_suspended)
return;
console_locked = 1; console_locked = 1;
console_may_schedule = 1; console_may_schedule = 1;
} }
@ -926,6 +925,10 @@ int try_acquire_console_sem(void)
{ {
if (down_trylock(&console_sem)) if (down_trylock(&console_sem))
return -1; return -1;
if (console_suspended) {
up(&console_sem);
return -1;
}
console_locked = 1; console_locked = 1;
console_may_schedule = 0; console_may_schedule = 0;
return 0; return 0;
@ -979,7 +982,7 @@ void release_console_sem(void)
unsigned wake_klogd = 0; unsigned wake_klogd = 0;
if (console_suspended) { if (console_suspended) {
up(&secondary_console_sem); up(&console_sem);
return; return;
} }