Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

x86, boot: Pass cmd_line_ptr with unsigned long instead

Browse source 
boot/compressed/misc.c is used for bzImage in 64bit and 32bit, and
cmd_line_ptr could point to buffer that is above 4g, cmd_line_ptr
should be 64bit otherwise high 32bit will be capped out.

So need to change data type to unsigned long, that will be 64bit get
correct address of command line buffer.

And it is still ok with 32bit bzImage, because unsigned long on 32bit kernel
is still 32bit.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Link: http://lkml.kernel.org/r/1359058816-7615-19-git-send-email-yinghai@kernel.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
This commit is contained in:
Yinghai Lu 2013-01-24 12:19:59 -08:00 committed by H. Peter Anvin
parent 16a4baa642
commit 3db07e70f0
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/x86/boot/boot.h
View file

@ -285,11 +285,11 @@ struct biosregs {
void intcall(u8 int_no, const struct biosregs *ireg, struct biosregs *oreg); void intcall(u8 int_no, const struct biosregs *ireg, struct biosregs *oreg);
/* cmdline.c */ /* cmdline.c */
int __cmdline_find_option(u32 cmdline_ptr, const char *option, char *buffer, int bufsize); int __cmdline_find_option(unsigned long cmdline_ptr, const char *option, char *buffer, int bufsize);
int __cmdline_find_option_bool(u32 cmdline_ptr, const char *option); int __cmdline_find_option_bool(unsigned long cmdline_ptr, const char *option);
static inline int cmdline_find_option(const char *option, char *buffer, int bufsize) static inline int cmdline_find_option(const char *option, char *buffer, int bufsize)
{ {
u32 cmd_line_ptr = boot_params.hdr.cmd_line_ptr; unsigned long cmd_line_ptr = boot_params.hdr.cmd_line_ptr;
if (cmd_line_ptr >= 0x100000) if (cmd_line_ptr >= 0x100000)
return -1; /* inaccessible */ return -1; /* inaccessible */
@ -299,7 +299,7 @@ static inline int cmdline_find_option(const char *option, char *buffer, int bufs
static inline int cmdline_find_option_bool(const char *option) static inline int cmdline_find_option_bool(const char *option)
{ {
u32 cmd_line_ptr = boot_params.hdr.cmd_line_ptr; unsigned long cmd_line_ptr = boot_params.hdr.cmd_line_ptr;
if (cmd_line_ptr >= 0x100000) if (cmd_line_ptr >= 0x100000)
return -1; /* inaccessible */ return -1; /* inaccessible */

4
arch/x86/boot/cmdline.c
View file

@ -27,7 +27,7 @@ static inline int myisspace(u8 c)
* Returns the length of the argument (regardless of if it was * Returns the length of the argument (regardless of if it was
* truncated to fit in the buffer), or -1 on not found. * truncated to fit in the buffer), or -1 on not found.
*/ */
int __cmdline_find_option(u32 cmdline_ptr, const char *option, char *buffer, int bufsize) int __cmdline_find_option(unsigned long cmdline_ptr, const char *option, char *buffer, int bufsize)
{ {
addr_t cptr; addr_t cptr;
char c; char c;
@ -99,7 +99,7 @@ int __cmdline_find_option(u32 cmdline_ptr, const char *option, char *buffer, int
* Returns the position of that option (starts counting with 1) * Returns the position of that option (starts counting with 1)
* or 0 on not found * or 0 on not found
*/ */
int __cmdline_find_option_bool(u32 cmdline_ptr, const char *option) int __cmdline_find_option_bool(unsigned long cmdline_ptr, const char *option)
{ {
addr_t cptr; addr_t cptr;
char c; char c;