Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fs: buffer don't PageUptodate without page locked

Browse source 
__block_write_full_page is calling SetPageUptodate without the page locked.
This is unusual, but not incorrect, as PG_writeback is still set.

However the next patch will require that SetPageUptodate always be called with
the page locked.  Simply don't bother setting the page uptodate in this case
(it is unusual that the write path does such a thing anyway).  Instead just
leave it to the read side to bring the page uptodate when it notices that all
buffers are uptodate.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Nick Piggin 2007-05-06 14:49:05 -07:00 committed by Linus Torvalds
parent 6fe6900e1e
commit 3d67f2d7c0
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
fs/buffer.c
View file

@ -1700,17 +1700,8 @@ static int __block_write_full_page(struct inode *inode, struct page *page,
* clean. Someone wrote them back by hand with * clean. Someone wrote them back by hand with
* ll_rw_block/submit_bh. A rare case. * ll_rw_block/submit_bh. A rare case.
*/ */
int uptodate = 1;
do {
if (!buffer_uptodate(bh)) {
uptodate = 0;
break;
}
bh = bh->b_this_page;
} while (bh != head);
if (uptodate)
SetPageUptodate(page);
end_page_writeback(page); end_page_writeback(page);
/* /*
* The page and buffer_heads can be released at any time from * The page and buffer_heads can be released at any time from
* here on. * here on.