Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

driver: uio: fix possible memory leak in __uio_register_device

Browse source 
[ Upstream commit 1a392b3de7c5747506b38fc14b2e79977d3c7770 ]

'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b3315 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Liu Jian 2019-01-23 06:45:37 +08:00 • committed by Greg Kroah-Hartman
parent 1dedc9d926
commit 3b656e7c16
1 changed files with 3 additions and 1 deletions

4
drivers/uio/uio.c
View file

@ -938,8 +938,10 @@ int __uio_register_device(struct module *owner,
atomic_set(&idev->event, 0);
ret = uio_get_minor(idev);
if (ret)
if (ret) {
kfree(idev);
return ret;
}
idev->dev.devt = MKDEV(uio_major, idev->minor);
idev->dev.class = &uio_class;