Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

net ax25: Reorder ax25_exit to remove races.

Browse source 
While reviewing the sysctl code in ax25 I spotted races in ax25_exit
where it is possible to receive notifications and packets after already
freeing up some of the data structures needed to process those
notifications and updates.

Call unregister_netdevice_notifier early so that the rest of the cleanup
code does not need to deal with network devices.  This takes advantage
of my recent enhancement to unregister_netdevice_notifier to send
unregister notifications of all network devices that are current
registered.

Move the unregistration for packet types, socket types and protocol
types before we cleanup any of the ax25 data structures to remove the
possibilities of other races.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric W. Biederman 2012-04-18 16:11:23 +00:00 committed by David S. Miller
parent 996f73937c
commit 3adadc08cc
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
net/ax25/af_ax25.c
View file

@ -2011,16 +2011,17 @@ static void __exit ax25_exit(void)
proc_net_remove(&init_net, "ax25_route"); proc_net_remove(&init_net, "ax25_route");
proc_net_remove(&init_net, "ax25"); proc_net_remove(&init_net, "ax25");
proc_net_remove(&init_net, "ax25_calls"); proc_net_remove(&init_net, "ax25_calls");
ax25_rt_free();
ax25_uid_free();
ax25_dev_free();
ax25_unregister_sysctl();
unregister_netdevice_notifier(&ax25_dev_notifier); unregister_netdevice_notifier(&ax25_dev_notifier);
ax25_unregister_sysctl();
dev_remove_pack(&ax25_packet_type); dev_remove_pack(&ax25_packet_type);
sock_unregister(PF_AX25); sock_unregister(PF_AX25);
proto_unregister(&ax25_proto); proto_unregister(&ax25_proto);
ax25_rt_free();
ax25_uid_free();
ax25_dev_free();
} }
module_exit(ax25_exit); module_exit(ax25_exit);