Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] affs: possible null pointer dereference in affs_rename()

Browse source 
If affs_bread() fails, the exit path calls mark_buffer_dirty_inode() with a
NULL argument.

Coverity CID: 312.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Florin Malita 2006-05-25 18:44:23 -07:00 committed by Linus Torvalds
parent 9084533e79
commit 3ac8141366
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/affs/namei.c
View file

@ -416,10 +416,9 @@ affs_rename(struct inode *old_dir, struct dentry *old_dentry,
return retval; return retval;
} }
retval = -EIO;
bh = affs_bread(sb, old_dentry->d_inode->i_ino); bh = affs_bread(sb, old_dentry->d_inode->i_ino);
if (!bh) if (!bh)
goto done; return -EIO;
/* Remove header from its parent directory. */ /* Remove header from its parent directory. */
affs_lock_dir(old_dir); affs_lock_dir(old_dir);