Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

kconfig: fix /dev/null breakage

Browse source 
While running "make menuconfig" and "make mrproper"
some people experienced that /dev/null suddenly changed
permissions or suddenly became a regular file.
The main reason was that /dev/null was used as output
to gcc in the check-lxdialog.sh script and gcc did
some strange things with the output file; in this
case /dev/null when it errorred out.

Following patch implements a suggestion
from Bryan O'Sullivan <bos@serpentine.com> to
use gcc -print-file-name=libxxx.so.

Also the Makefile is adjusted to not resolve value of
HOST_EXTRACFLAGS and HOST_LOADLIBES until they are actually used.
This prevents us from calling gcc when running make *clean/mrproper

Thanks to Eyal Lebedinsky <eyal@eyal.emu.id.au> and
Jean Delvare <khali@linux-fr.org> for the first error reports.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
This commit is contained in:
Sam Ravnborg 2006-01-21 12:03:09 +01:00
parent 3ee68c4af3
commit 3835f82183
2 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scripts/kconfig/lxdialog/Makefile
View file

@ -2,8 +2,11 @@
# #
check-lxdialog := $(srctree)/$(src)/check-lxdialog.sh check-lxdialog := $(srctree)/$(src)/check-lxdialog.sh
HOST_EXTRACFLAGS:= $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags)
HOST_LOADLIBES := $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) # Use reursively expanded variables so we do not call gcc unless
# we really need to do so. (Do not call gcc as part of make mrproper)
HOST_EXTRACFLAGS = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags)
HOST_LOADLIBES = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
HOST_EXTRACFLAGS += -DLOCALE HOST_EXTRACFLAGS += -DLOCALE

14
scripts/kconfig/lxdialog/check-lxdialog.sh
View file

@ -4,17 +4,17 @@
# What library to link # What library to link
ldflags() ldflags()
{ {
echo "main() {}" | $cc -lncursesw -xc - -o /dev/null 2> /dev/null $cc -print-file-name=libncursesw.so | grep -q /
if [ $? -eq 0 ]; then if [ $? -eq 0 ]; then
echo '-lncursesw' echo '-lncursesw'
exit exit
fi fi
echo "main() {}" | $cc -lncurses -xc - -o /dev/null 2> /dev/null $cc -print-file-name=libncurses.so | grep -q /
if [ $? -eq 0 ]; then if [ $? -eq 0 ]; then
echo '-lncurses' echo '-lncurses'
exit exit
fi fi
echo "main() {}" | $cc -lcurses -xc - -o /dev/null 2> /dev/null $cc -print-file-name=libcurses.so | grep -q /
if [ $? -eq 0 ]; then if [ $? -eq 0 ]; then
echo '-lcurses' echo '-lcurses'
exit exit
@ -36,10 +36,13 @@ ccflags()
fi fi
} }
compiler="" # Temp file, try to clean up after us
tmp=.lxdialog.tmp
trap "rm -f $tmp" 0 1 2 3 15
# Check if we can link to ncurses # Check if we can link to ncurses
check() { check() {
echo "main() {}" | $cc -xc - -o /dev/null 2> /dev/null echo "main() {}" | $cc -xc - -o $tmp 2> /dev/null
if [ $? != 0 ]; then if [ $? != 0 ]; then
echo " *** Unable to find the ncurses libraries." 1>&2 echo " *** Unable to find the ncurses libraries." 1>&2
echo " *** make menuconfig require the ncurses libraries" 1>&2 echo " *** make menuconfig require the ncurses libraries" 1>&2
@ -59,6 +62,7 @@ if [ $# == 0 ]; then
exit 1 exit 1
fi fi
cc=""
case "$1" in case "$1" in
"-check") "-check")
shift shift