Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag

Browse source 
We must make sure that the RTC_DEV_BUSY flag has proper lock semantics,
i.e.  that the RTC_DEV_BUSY stores clearing the flag don't get reordered
before the preceeding stores and loads and vice versa.

Spotted by Nick Piggin.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: David Brownell <david-b@pacbell.net>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jiri Kosina 2007-12-04 23:45:05 -08:00 committed by Linus Torvalds
parent 5cd17569fd
commit 372a302e9a
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/rtc/interface.c
View file

@ -293,7 +293,7 @@ int rtc_irq_register(struct rtc_device *rtc, struct rtc_task *task)
return -EINVAL; return -EINVAL;
/* Cannot register while the char dev is in use */ /* Cannot register while the char dev is in use */
if (test_and_set_bit(RTC_DEV_BUSY, &rtc->flags)) if (test_and_set_bit_lock(RTC_DEV_BUSY, &rtc->flags))
return -EBUSY; return -EBUSY;
spin_lock_irq(&rtc->irq_task_lock); spin_lock_irq(&rtc->irq_task_lock);
@ -303,7 +303,7 @@ int rtc_irq_register(struct rtc_device *rtc, struct rtc_task *task)
} }
spin_unlock_irq(&rtc->irq_task_lock); spin_unlock_irq(&rtc->irq_task_lock);
clear_bit(RTC_DEV_BUSY, &rtc->flags); clear_bit_unlock(RTC_DEV_BUSY, &rtc->flags);
return retval; return retval;
} }

6
drivers/rtc/rtc-dev.c
View file

@ -26,7 +26,7 @@ static int rtc_dev_open(struct inode *inode, struct file *file)
struct rtc_device, char_dev); struct rtc_device, char_dev);
const struct rtc_class_ops *ops = rtc->ops; const struct rtc_class_ops *ops = rtc->ops;
if (test_and_set_bit(RTC_DEV_BUSY, &rtc->flags)) if (test_and_set_bit_lock(RTC_DEV_BUSY, &rtc->flags))
return -EBUSY; return -EBUSY;
file->private_data = rtc; file->private_data = rtc;
@ -41,7 +41,7 @@ static int rtc_dev_open(struct inode *inode, struct file *file)
} }
/* something has gone wrong */ /* something has gone wrong */
clear_bit(RTC_DEV_BUSY, &rtc->flags); clear_bit_unlock(RTC_DEV_BUSY, &rtc->flags);
return err; return err;
} }
@ -402,7 +402,7 @@ static int rtc_dev_release(struct inode *inode, struct file *file)
if (rtc->ops->release) if (rtc->ops->release)
rtc->ops->release(rtc->dev.parent); rtc->ops->release(rtc->dev.parent);
clear_bit(RTC_DEV_BUSY, &rtc->flags); clear_bit_unlock(RTC_DEV_BUSY, &rtc->flags);
return 0; return 0;
} }