Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tools/kvm_stat: avoid 'is' for equality checks

Browse source 
Use '==' for equality checks and 'is' when comparing identities.

An example where '==' and 'is' behave differently:
>>> a = 4242
>>> a == 4242
True
>>> a is 4242
False

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Marc Hartmayer 2018-01-09 13:27:04 +01:00 committed by Paolo Bonzini
parent 0eb578009a
commit 369d5a85bb
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/kvm/kvm_stat/kvm_stat
View file

@ -1085,7 +1085,7 @@ class Tui(object):
stats = self.stats.get(self._display_guests) stats = self.stats.get(self._display_guests)
total = 0. total = 0.
for key, values in stats.items(): for key, values in stats.items():
if key.find('(') is -1: if key.find('(') == -1:
total += values.value total += values.value
if self._sorting == SORT_DEFAULT: if self._sorting == SORT_DEFAULT:
@ -1110,7 +1110,7 @@ class Tui(object):
self.screen.addstr(row, 1, '%-40s %10d%7.1f %8s' % self.screen.addstr(row, 1, '%-40s %10d%7.1f %8s' %
(key, values.value, values.value * 100 / total, (key, values.value, values.value * 100 / total,
cur)) cur))
if cur is not '' and key.find('(') is -1: if cur != '' and key.find('(') == -1:
tavg += cur tavg += cur
row += 1 row += 1
if row == 3: if row == 3: