Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

leds: leds-88pm860x: drop devm_kfree of devm_kzalloc'd data

Browse source 
The devm_kfree function allocates memory that is released
when a driver detaches. Thus, there is no reason to explicitly
call devm_kfree in probe or remove functions.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
This commit is contained in:
Jingoo Han 2012-10-28 21:31:07 -07:00 committed by Bryan Wu
parent 1b21ec5a28
commit 3651c4b904
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/leds/leds-88pm860x.c
View file

@ -165,15 +165,13 @@ static int pm860x_led_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_REG, "control"); res = platform_get_resource_byname(pdev, IORESOURCE_REG, "control");
if (!res) { if (!res) {
dev_err(&pdev->dev, "No REG resource for control\n"); dev_err(&pdev->dev, "No REG resource for control\n");
ret = -ENXIO; return -ENXIO;
goto out;
} }
data->reg_control = res->start; data->reg_control = res->start;
res = platform_get_resource_byname(pdev, IORESOURCE_REG, "blink"); res = platform_get_resource_byname(pdev, IORESOURCE_REG, "blink");
if (!res) { if (!res) {
dev_err(&pdev->dev, "No REG resource for blink\n"); dev_err(&pdev->dev, "No REG resource for blink\n");
ret = -ENXIO; return -ENXIO;
goto out;
} }
data->reg_blink = res->start; data->reg_blink = res->start;
memset(data->name, 0, MFD_NAME_SIZE); memset(data->name, 0, MFD_NAME_SIZE);
@ -224,9 +222,6 @@ static int pm860x_led_probe(struct platform_device *pdev)
} }
pm860x_led_set(&data->cdev, 0); pm860x_led_set(&data->cdev, 0);
return 0; return 0;
out:
devm_kfree(&pdev->dev, data);
return ret;
} }
static int pm860x_led_remove(struct platform_device *pdev) static int pm860x_led_remove(struct platform_device *pdev)