Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[S390] sclp_async: potential buffer overflow

Browse source 
"len" hasn't been properly range checked so we shouldn't use it as an
array offset.  This can only be written to by root but it would still be
annoying to accidentally write more than 3 characters and corrupt your
memory.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Dan Carpenter 2010-04-09 13:42:59 +02:00 committed by Martin Schwidefsky
parent d7015c120e
commit 35ac734f72
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/s390/char/sclp_async.c
View file

@ -85,7 +85,7 @@ static int proc_handler_callhome(struct ctl_table *ctl, int write,
rc = copy_from_user(buf, buffer, sizeof(buf)); rc = copy_from_user(buf, buffer, sizeof(buf));
if (rc != 0) if (rc != 0)
return -EFAULT; return -EFAULT;
buf[len - 1] = '\0'; buf[sizeof(buf) - 1] = '\0';
if (strict_strtoul(buf, 0, &val) != 0) if (strict_strtoul(buf, 0, &val) != 0)
return -EINVAL; return -EINVAL;
if (val != 0 && val != 1) if (val != 0 && val != 1)