Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

eeepc-laptop: re-add check for eeepc->backlight == NULL

Browse source 
As Corentin points out, we do not create a backlight device if the ACPI
video driver is able to provide equivalent functionality. So we do need
to check before we try to update the backlight device.

We now ignore brightness events completely if we have not created a
backlight device.  This is slightly more cautious than the original
check.

Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
Alan Jenkins 2009-12-03 07:45:15 +00:00 committed by Len Brown
parent f90be87430
commit 325fb8e9ae
1 changed files with 23 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
drivers/platform/x86/eeepc-laptop.c
View file

@ -1230,27 +1230,35 @@ static void eeepc_acpi_notify(struct acpi_device *device, u32 event)
dev_name(&device->dev), event, dev_name(&device->dev), event,
count); count);
/* Brightness events are special */
if (event >= NOTIFY_BRN_MIN && event <= NOTIFY_BRN_MAX) { if (event >= NOTIFY_BRN_MIN && event <= NOTIFY_BRN_MAX) {
int old_brightness, new_brightness;
/* Update backlight device. */ /* Ignore them completely if the acpi video driver is used */
old_brightness = eeepc_backlight_notify(eeepc); if (eeepc->backlight_device != NULL) {
int old_brightness, new_brightness;
/* Convert brightness event to keypress (obsolescent hack). */ /* Update the backlight device. */
new_brightness = event - NOTIFY_BRN_MIN; old_brightness = eeepc_backlight_notify(eeepc);
if (new_brightness < old_brightness) { /* Convert event to keypress (obsolescent hack) */
event = NOTIFY_BRN_MIN; /* brightness down */ new_brightness = event - NOTIFY_BRN_MIN;
} else if (new_brightness > old_brightness) {
event = NOTIFY_BRN_MAX; /* brightness up */ if (new_brightness < old_brightness) {
} else { event = NOTIFY_BRN_MIN; /* brightness down */
/* } else if (new_brightness > old_brightness) {
* no change in brightness - already at min/max, event = NOTIFY_BRN_MAX; /* brightness up */
* event will be desired value (or else ignored). } else {
*/ /*
* no change in brightness - already at min/max,
* event will be desired value (or else ignored)
*/
}
eeepc_input_notify(eeepc, event);
} }
} else {
/* Everything else is a bona-fide keypress event */
eeepc_input_notify(eeepc, event);
} }
eeepc_input_notify(eeepc, event);
} }
static void cmsg_quirk(struct eeepc_laptop *eeepc, int cm, const char *name) static void cmsg_quirk(struct eeepc_laptop *eeepc, int cm, const char *name)