Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nilfs2: fix potential leak of dirty data on umount

Browse source 
This fixes incorrect usage of nilfs_segctor_confirm() test function in
nilfs_segctor_destroy(); nilfs_segctor_confirm() returns zero if the
filesystem is not clean, so its use in nilfs_segctor_destroy() needs
inversion.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
This commit is contained in:
Ryusuke Konishi 2010-01-31 12:39:50 +09:00
parent abe94c756c
commit 3256a05531
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/nilfs2/segment.c
View file

@ -2829,7 +2829,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci)
|| sci->sc_seq_request != sci->sc_seq_done); || sci->sc_seq_request != sci->sc_seq_done);
spin_unlock(&sci->sc_state_lock); spin_unlock(&sci->sc_state_lock);
if (flag || nilfs_segctor_confirm(sci)) if (flag || !nilfs_segctor_confirm(sci))
nilfs_segctor_write_out(sci); nilfs_segctor_write_out(sci);
WARN_ON(!list_empty(&sci->sc_copied_buffers)); WARN_ON(!list_empty(&sci->sc_copied_buffers));