Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

powerpc/macintosh: Fix unsigned check in smu_sat_get_sdb_partition()

Browse source 
i2c_smbus_read_word_data() returns a s32, which may be negative
but unsigned len cannot be negative.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
roel kluin 2008-11-29 01:17:27 +00:00 committed by Paul Mackerras
parent e6a437eba0
commit 2fd091f3ee
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/macintosh/windfarm_smu_sat.c
View file

@ -87,11 +87,12 @@ struct smu_sdbp_header *smu_sat_get_sdb_partition(unsigned int sat_id, int id,
return NULL; return NULL;
} }
len = i2c_smbus_read_word_data(&sat->i2c, 9); err = i2c_smbus_read_word_data(&sat->i2c, 9);
if (len < 0) { if (err < 0) {
printk(KERN_ERR "smu_sat_get_sdb_part rd len error\n"); printk(KERN_ERR "smu_sat_get_sdb_part rd len error\n");
return NULL; return NULL;
} }
len = err;
if (len == 0) { if (len == 0) {
printk(KERN_ERR "smu_sat_get_sdb_part no partition %x\n", id); printk(KERN_ERR "smu_sat_get_sdb_part no partition %x\n", id);
return NULL; return NULL;