Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

USB: report submission of active URBs

Browse source 
This patch (as1633) changes slightly the way usbcore handled
submissions of URBs that are already active.  It will now return
-EBUSY rather than -EINVAL, and it will call WARN_ONCE to draw
people's attention to the bug.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alan Stern 2012-11-07 16:35:00 -05:00 committed by Greg Kroah-Hartman
parent 2656a9abcf
commit 2f02bc8af3
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Documentation/usb/error-codes.txt
View file

@ -21,6 +21,8 @@ Non-USB-specific:
USB-specific: USB-specific:
-EBUSY The URB is already active.
-ENODEV specified USB-device or bus doesn't exist -ENODEV specified USB-device or bus doesn't exist
-ENOENT specified interface or endpoint does not exist or -ENOENT specified interface or endpoint does not exist or

7
drivers/usb/core/urb.c
View file

@ -321,8 +321,13 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
struct usb_host_endpoint *ep; struct usb_host_endpoint *ep;
int is_out; int is_out;
if (!urb || urb->hcpriv || !urb->complete) if (!urb || !urb->complete)
return -EINVAL; return -EINVAL;
if (urb->hcpriv) {
WARN_ONCE(1, "URB %p submitted while active\n", urb);
return -EBUSY;
}
dev = urb->dev; dev = urb->dev;
if ((!dev) || (dev->state < USB_STATE_UNAUTHENTICATED)) if ((!dev) || (dev->state < USB_STATE_UNAUTHENTICATED))
return -ENODEV; return -ENODEV;