Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[S390] remove redundant stack check option

Browse source 
Newer gcc versions offer an architecture-independent option to check
the stack size and warn if it reaches a certain limit. This option
already existed for s390 by using -mwarn-dynamicstack. Since one
stack check option is enough remove the s390 specific stack check
but keep the option that warns about dynamic stack usage because
that is not covered by the generic option.

Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Jan Glauber 2011-03-15 17:08:19 +01:00 committed by Martin Schwidefsky
parent 521cb40b0c
commit 2c190da477
2 changed files with 6 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
arch/s390/Kconfig
View file

@ -341,26 +341,16 @@ config STACK_GUARD
The minimum size for the stack guard should be 256 for 31 bit and The minimum size for the stack guard should be 256 for 31 bit and
512 for 64 bit. 512 for 64 bit.
config WARN_STACK config WARN_DYNAMIC_STACK
def_bool n def_bool n
prompt "Emit compiler warnings for function with broken stack usage" prompt "Emit compiler warnings for function with dynamic stack usage"
help help
This option enables the compiler options -mwarn-framesize and This option enables the compiler option -mwarn-dynamicstack. If the
-mwarn-dynamicstack. If the compiler supports these options it compiler supports this options generates warnings for functions
will generate warnings for function which either use alloca or that dynamically allocate stack space using alloca.
create a stack frame bigger than CONFIG_WARN_STACK_SIZE.
Say N if you are unsure. Say N if you are unsure.
config WARN_STACK_SIZE
int "Maximum frame size considered safe (128-2048)"
range 128 2048
depends on WARN_STACK
default "2048"
help
This allows you to specify the maximum frame size a function may
have without the compiler complaining about it.
config ARCH_POPULATES_NODE_MAP config ARCH_POPULATES_NODE_MAP
def_bool y def_bool y

3
arch/s390/Makefile
View file

@ -80,8 +80,7 @@ endif
endif endif
ifeq ($(call cc-option-yn,-mwarn-dynamicstack),y) ifeq ($(call cc-option-yn,-mwarn-dynamicstack),y)
cflags-$(CONFIG_WARN_STACK) += -mwarn-dynamicstack cflags-$(CONFIG_WARN_DYNAMIC_STACK) += -mwarn-dynamicstack
cflags-$(CONFIG_WARN_STACK) += -mwarn-framesize=$(CONFIG_WARN_STACK_SIZE)
endif endif
KBUILD_CFLAGS += -mbackchain -msoft-float $(cflags-y) KBUILD_CFLAGS += -mbackchain -msoft-float $(cflags-y)