Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[SPARC64]: Fix section error in sparcspkr

Browse source 
With a sparc64 defconfig modified to set CONFIG_HOTPLUG=n
the following error happened during link of vmlinux:

local symbol 0: discarded in section `.devexit.text' from drivers/built-in.o
local symbol 1: discarded in section `.devexit.text' from drivers/built-in.o

(The error message above is from kbuild.git but it happens in mainline too)

The error happens becase there is a reference from .text/.data to a
function marked __devexit. With CONFIG_HOTPLUG=n all code marked
__devexit are discarded and the linker complains.

It was tracked down to sparcspkr.c which were missing __devexit_p()
around the function pointers.

Unfortunately modpost did not catch this since modpost do not warn
about references from .data to .devexit from variables named *_driver.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sam Ravnborg 2008-01-21 17:25:37 -08:00 committed by David S. Miller
parent a1f35ba374
commit 2ad913babd
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/input/misc/sparcspkr.c
View file

@ -195,7 +195,7 @@ static struct of_platform_driver ebus_beep_driver = {
.name = "beep", .name = "beep",
.match_table = ebus_beep_match, .match_table = ebus_beep_match,
.probe = ebus_beep_probe, .probe = ebus_beep_probe,
.remove = sparcspkr_remove, .remove = __devexit_p(sparcspkr_remove),
.shutdown = sparcspkr_shutdown, .shutdown = sparcspkr_shutdown,
}; };
@ -236,7 +236,7 @@ static struct of_platform_driver isa_beep_driver = {
.name = "beep", .name = "beep",
.match_table = isa_beep_match, .match_table = isa_beep_match,
.probe = isa_beep_probe, .probe = isa_beep_probe,
.remove = sparcspkr_remove, .remove = __devexit_p(sparcspkr_remove),
.shutdown = sparcspkr_shutdown, .shutdown = sparcspkr_shutdown,
}; };