Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

drm/vblank: Add FIXME comments about moving the vblank ts hooks

Browse source 
This is going to be a bit too much, but good to have at least a small
note about where this should all head towards.

Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170509140329.24114-3-daniel.vetter@ffwll.ch
This commit is contained in:
Daniel Vetter 2017-05-09 16:03:27 +02:00
parent 3fcdcb2709
commit 2a39b88bc1
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
include/drm/drm_drv.h
View file

@ -276,6 +276,11 @@ struct drm_driver {
* constant but unknown small number of scanlines wrt. real scanout * constant but unknown small number of scanlines wrt. real scanout
* position. * position.
* *
* FIXME:
*
* Since this is a helper to implement @get_vblank_timestamp, we should
* move it to &struct drm_crtc_helper_funcs, like all the other
* helper-internal hooks.
*/ */
int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe, int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe,
unsigned int flags, int *vpos, int *hpos, unsigned int flags, int *vpos, int *hpos,
@ -319,6 +324,11 @@ struct drm_driver {
* *
* True on success, false on failure, which means the core should * True on success, false on failure, which means the core should
* fallback to a simple timestamp taken in drm_crtc_handle_vblank(). * fallback to a simple timestamp taken in drm_crtc_handle_vblank().
*
* FIXME:
*
* We should move this hook to &struct drm_crtc_funcs like all the other
* vblank hooks.
*/ */
bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe, bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe,
int *max_error, int *max_error,