Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

OMAPDSS: APPLY: fix NULL pointer deref when mgr is not set

Browse source 
extra_info_update_ongoing() goes through all overlays, but doesn't check
if the overlay is connected to a manager. This leads to a crash whenever
an overlay has been detached.

Add a check to skip the non-connected overlays.

Reported-by: Rob Clark <rob@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Rob Clark 2011-12-17 13:28:52 -06:00 committed by Tomi Valkeinen
parent 6ea9b31792
commit 1f3f53ae51
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/video/omap2/dss/apply.c
View file

@ -327,6 +327,9 @@ static bool extra_info_update_ongoing(void)
ovl = omap_dss_get_overlay(i); ovl = omap_dss_get_overlay(i);
op = get_ovl_priv(ovl); op = get_ovl_priv(ovl);
if (!ovl->manager)
continue;
mp = get_mgr_priv(ovl->manager); mp = get_mgr_priv(ovl->manager);
if (!mp->enabled) if (!mp->enabled)