Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ACER: Fix Smatch double-free issue

Browse source 
The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor"
from Jun 1, 2012, leads to the following Smatch warning:
drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy()
         error: don't call input_free_device() after input_unregister_device()

drivers/platform/x86/acer-wmi.c
  1883  static void acer_wmi_accel_destroy(void)
  1884  {
  1885          input_unregister_device(acer_wmi_accel_dev);
  1886          input_free_device(acer_wmi_accel_dev);
  1887  }

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Fengguang Wu <wfg@linux.intel.com>
Cc: joeyli <jlee@suse.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
Marek Vasut 2012-07-05 01:30:10 +02:00 committed by Matthew Garrett
parent 24237c43aa
commit 1bfaf1d5bc
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/platform/x86/acer-wmi.c
View file

@ -1883,7 +1883,6 @@ static int __init acer_wmi_accel_setup(void)
static void acer_wmi_accel_destroy(void)
{
input_unregister_device(acer_wmi_accel_dev);
input_free_device(acer_wmi_accel_dev);
}
static int __init acer_wmi_input_setup(void)