[SCSI] aha152x: Close narrow race in release
We were releasing the IRQ before removing the host, so commands could still be coming in which would never be seen by the interrupt handler. Just remove the host before releasing the IRQ to close this race. Signed-off-by: Matthew Wilcox <matthew@wil.cx> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
parent
dffe807cdb
commit
1bd4057346
1 changed files with 2 additions and 2 deletions
|
@ -907,9 +907,10 @@ struct Scsi_Host *aha152x_probe_one(struct aha152x_setup *setup)
|
|||
|
||||
void aha152x_release(struct Scsi_Host *shpnt)
|
||||
{
|
||||
if(!shpnt)
|
||||
if (!shpnt)
|
||||
return;
|
||||
|
||||
scsi_remove_host(shpnt);
|
||||
if (shpnt->irq)
|
||||
free_irq(shpnt->irq, shpnt);
|
||||
|
||||
|
@ -923,7 +924,6 @@ void aha152x_release(struct Scsi_Host *shpnt)
|
|||
pnp_device_detach(HOSTDATA(shpnt)->pnpdev);
|
||||
#endif
|
||||
|
||||
scsi_remove_host(shpnt);
|
||||
list_del(&HOSTDATA(shpnt)->host_list);
|
||||
scsi_host_put(shpnt);
|
||||
}
|
||||
|
|
Loading…
Add table
Reference in a new issue