Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

stmmac: remove two useless initialisations

Browse source 
This patch removes two useless initialisations in the
stmmac_rx and stmmac_tx functions.
In the former, the count variable was reset twice and in
the stmmac_tx we only need to increment the dirty pointer
w/o setting the entry variable.

v2: review the subject and comment that was not clear in my
first version.

Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Giuseppe CAVALLARO 2012-06-04 06:36:22 +00:00 committed by David S. Miller
parent f07d90107c
commit 13497f5867
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
View file

@ -677,7 +677,7 @@ static void stmmac_tx(struct stmmac_priv *priv)
priv->hw->desc->release_tx_desc(p); priv->hw->desc->release_tx_desc(p);
entry = (++priv->dirty_tx) % txsize; priv->dirty_tx++;
} }
if (unlikely(netif_queue_stopped(priv->dev) && if (unlikely(netif_queue_stopped(priv->dev) &&
stmmac_tx_avail(priv) > STMMAC_TX_THRESH(priv))) { stmmac_tx_avail(priv) > STMMAC_TX_THRESH(priv))) {
@ -1307,7 +1307,6 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit)
display_ring(priv->dma_rx, rxsize); display_ring(priv->dma_rx, rxsize);
} }
#endif #endif
count = 0;
while (!priv->hw->desc->get_rx_owner(p)) { while (!priv->hw->desc->get_rx_owner(p)) {
int status; int status;