Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PA-RISC] Fix must_check warnings in drivers.c

Browse source 
Panic if we can't register the parisc bus or the root parisc device.
There's no way we can boot without them, so let the user know ASAP.

If we can't register a parisc device, handle the failure gracefully.

Signed-off-by: Matthew Wilcox <willy@parisc-linux.org>
This commit is contained in:
Matthew Wilcox 2006-10-04 13:37:41 -06:00 committed by Matthew Wilcox
parent f64ef29503
commit 1070c9655b
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
arch/parisc/kernel/drivers.c
View file

@ -424,7 +424,10 @@ struct parisc_device * create_tree_node(char id, struct device *parent)
/* make the generic dma mask a pointer to the parisc one */ /* make the generic dma mask a pointer to the parisc one */
dev->dev.dma_mask = &dev->dma_mask; dev->dev.dma_mask = &dev->dma_mask;
dev->dev.coherent_dma_mask = dev->dma_mask; dev->dev.coherent_dma_mask = dev->dma_mask;
device_register(&dev->dev); if (!device_register(&dev->dev)) {
kfree(dev);
return NULL;
}
return dev; return dev;
} }
@ -850,8 +853,10 @@ static void print_parisc_device(struct parisc_device *dev)
*/ */
void init_parisc_bus(void) void init_parisc_bus(void)
{ {
bus_register(&parisc_bus_type); if (!bus_register(&parisc_bus_type))
device_register(&root); panic("Could not register PA-RISC bus type\n");
if (!device_register(&root))
panic("Could not register PA-RISC root device\n");
get_device(&root); get_device(&root);
} }