Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

rtc: rtc-sh: Fix up oops in early periodic freq assignment.

Browse source 
With the reordered init order, the rtc device is not registered until
later, while sh_rtc_irq_set_freq() was attempting to assign ->irq_freq
directly, resulting in an oops. This is handled by the upper layers for
us, so just kill off the problematic dereference completely.

Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
Paul Mundt 2009-09-09 12:13:01 +09:00
parent e7a963ef20
commit 1043bf5c95
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/rtc/rtc-sh.c
View file

@ -283,10 +283,8 @@ static int sh_rtc_irq_set_freq(struct device *dev, int freq)
ret = -ENOTSUPP; ret = -ENOTSUPP;
} }
if (ret == 0) { if (ret == 0)
rtc->periodic_freq |= tmp; rtc->periodic_freq |= tmp;
rtc->rtc_dev->irq_freq = freq;
}
spin_unlock_irq(&rtc->lock); spin_unlock_irq(&rtc->lock);
return ret; return ret;