Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[XFRM/RTNETLINK]: Decrement qlen properly in {xfrm_,rt}netlink_rcv().

Browse source 
If we free up a partially processed packet because it's
skb->len dropped to zero, we need to decrement qlen because
we are dropping out of the top-level loop so it will do
the decrement for us.

Spotted by Herbert Xu.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller 2005-05-03 16:15:59 -07:00 committed by David S. Miller
parent 09e1430598
commit 0f4821e7b9
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/core/rtnetlink.c
View file

@ -632,8 +632,10 @@ static void rtnetlink_rcv(struct sock *sk, int len)
if (skb->len) if (skb->len)
skb_queue_head(&sk->sk_receive_queue, skb_queue_head(&sk->sk_receive_queue,
skb); skb);
else else {
kfree_skb(skb); kfree_skb(skb);
qlen--;
}
break; break;
} }
kfree_skb(skb); kfree_skb(skb);

4
net/xfrm/xfrm_user.c
View file

@ -1024,8 +1024,10 @@ static void xfrm_netlink_rcv(struct sock *sk, int len)
if (skb->len) if (skb->len)
skb_queue_head(&sk->sk_receive_queue, skb_queue_head(&sk->sk_receive_queue,
skb); skb);
else else {
kfree_skb(skb); kfree_skb(skb);
qlen--;
}
break; break;
} }
kfree_skb(skb); kfree_skb(skb);