Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

arch/arm/mach-omap2/dma.c: Convert IS_ERR result to PTR_ERR

Browse source 
This code elsewhere returns a negative constant to an indicate an error,
while IS_ERR returns the result of a >= operation.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
@@

 if (...) { ...
- return IS_ERR(x);
+ return PTR_ERR(x);
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
This commit is contained in:
Julia Lawall 2011-01-27 15:49:06 +00:00 • committed by Tony Lindgren
parent afb7d7099e
commit 0e6d8cad44
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
arch/arm/mach-omap2/dma.c
View file

@ -264,7 +264,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused)
if (IS_ERR(od)) { if (IS_ERR(od)) {
pr_err("%s: Cant build omap_device for %s:%s.\n", pr_err("%s: Cant build omap_device for %s:%s.\n",
__func__, name, oh->name); __func__, name, oh->name);
return IS_ERR(od); return PTR_ERR(od);
} }
mem = platform_get_resource(&od->pdev, IORESOURCE_MEM, 0); mem = platform_get_resource(&od->pdev, IORESOURCE_MEM, 0);