Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

arch/powerpc/sysdev/fsl_pci.c: add missing iounmap

Browse source 
Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
This commit is contained in:
Julia Lawall 2012-01-12 10:55:14 +01:00 committed by Kumar Gala
parent ba8438fb4e
commit 0cf572dc00
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
arch/powerpc/sysdev/fsl_pci.c
View file

@ -205,12 +205,12 @@ static void __init setup_pci_atmu(struct pci_controller *hose,
if (paddr_hi == paddr_lo) { if (paddr_hi == paddr_lo) {
pr_err("%s: No outbound window space\n", name); pr_err("%s: No outbound window space\n", name);
return ; goto out;
} }
if (paddr_lo == 0) { if (paddr_lo == 0) {
pr_err("%s: No space for inbound window\n", name); pr_err("%s: No space for inbound window\n", name);
return ; goto out;
} }
/* setup PCSRBAR/PEXCSRBAR */ /* setup PCSRBAR/PEXCSRBAR */
@ -357,6 +357,7 @@ static void __init setup_pci_atmu(struct pci_controller *hose,
(u64)hose->dma_window_size); (u64)hose->dma_window_size);
} }
out:
iounmap(pci); iounmap(pci);
} }