Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

NFC: Avoid gpio_free for invalid GPIO

Browse source 
ese_gpio was initialised with -EINVAL in case the gpio
is found invalid. While freeing up the resources in
case of probe failure, ese_gpio being an unsigned value
was being compared with numeric value, which will always
be true, hence leading to freeing up the gpio.

Checked if gpio is valid before freeing it up.

Change-Id: Ibfcc14984b2dc45c1dee51ba6a3d03109420be15
Signed-off-by: Bhuvan Varshney <bvarshne@codeaurora.org>
This commit is contained in:
Bhuvan Varshney 2019-03-20 13:26:27 +05:30
parent 642059a34f
commit 0bf56a42b5
1 changed files with 1 additions and 1 deletions

2
drivers/nfc/nq-nci.c
View file

@ -1295,7 +1295,7 @@ static int nqx_probe(struct i2c_client *client,
gpio_free(platform_data->clkreq_gpio);
err_ese_gpio:
/* optional gpio, not sure was configured in probe */
if (nqx_dev->ese_gpio > 0)
if (gpio_is_valid(platform_data->ese_gpio))
gpio_free(platform_data->ese_gpio);
err_firm_gpio:
gpio_free(platform_data->firm_gpio);