Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Coccinelle: doubletest: reduce side effect false positives

Browse source 
Ensure that the cited expression is not a function call or an
assignment to reduce the chance of false positives.

Slightly modify the warning message to indicate another source
of false positves.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
This commit is contained in:
Julia Lawall 2018-08-03 18:32:11 +02:00 committed by Masahiro Yamada
parent d6c6ab93e1
commit 09d4d9648b
1 changed files with 26 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
scripts/coccinelle/tests/doubletest.cocci
View file

@ -1,6 +1,7 @@
/// Find &&/|| operations that include the same argument more than once /// Find &&/|| operations that include the same argument more than once
//# A common source of false positives is when the argument performs a side //# A common source of false positives is when the expression, or
//# effect. //# another expresssion in the same && or || operation, performs a
//# side effect.
/// ///
// Confidence: Moderate // Confidence: Moderate
// Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2.
@ -20,20 +21,37 @@ position p;
@@ @@
( (
* E@p E@p || ... || E
|| ... || E
| |
* E@p E@p && ... && E
&& ... && E
) )
@script:python depends on org@ @bad@
expression r.E,e1,e2,fn;
position r.p;
assignment operator op;
@@
(
E@p
&
<+... \(fn(...)\|e1 op e2\|e1++\|e1--\|++e1\|--e1\) ...+>
)
@depends on context && !bad@
expression r.E;
position r.p;
@@
*E@p
@script:python depends on org && !bad@
p << r.p; p << r.p;
@@ @@
cocci.print_main("duplicated argument to && or ||",p) cocci.print_main("duplicated argument to && or ||",p)
@script:python depends on report@ @script:python depends on report && !bad@
p << r.p; p << r.p;
@@ @@