Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

checkpatch: do is not a possible type

Browse source 
A do without braces '{' may trigger a false possible type 'do' and then
this may be interpreted as an external definition of foo():

	do
		foo();
	while (bar);

Add do to the type exclusions.  Fix up tests so we can check for them.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andy Whitcroft 2008-10-15 22:02:29 -07:00 committed by Linus Torvalds
parent 5fdd23acf9
commit 0776e59460
1 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
scripts/checkpatch.pl
View file

@ -913,12 +913,22 @@ sub annotate_values {
sub possible { sub possible {
my ($possible, $line) = @_; my ($possible, $line) = @_;
print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1); print "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
if ($possible !~ /^(?:$Modifier|$Storage|$Type|DEFINE_\S+)$/ && if ($possible !~ /(?:
$possible ne 'goto' && $possible ne 'return' && ^(?:
$possible ne 'case' && $possible ne 'else' && $Modifier|
$possible ne 'asm' && $possible ne '__asm__' && $Storage|
$possible !~ /^(typedef|struct|enum)\b/) { $Type|
DEFINE_\S+|
goto|
return|
case|
else|
asm|__asm__|
do
)$|
^(?:typedef|struct|enum)\b
)/x) {
# Check for modifiers. # Check for modifiers.
$possible =~ s/\s*$Storage\s*//g; $possible =~ s/\s*$Storage\s*//g;
$possible =~ s/\s*$Sparse\s*//g; $possible =~ s/\s*$Sparse\s*//g;
@ -936,6 +946,8 @@ sub possible {
push(@typeList, $possible); push(@typeList, $possible);
} }
build_types(); build_types();
} else {
warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
} }
} }