Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tracing/ftrace: fix the check on nopped sites

Browse source 
Impact: fix a dynamic tracing failure

Recently, the function and function graph tracers failed to use dynamic
tracing after the following commit:

fa9d13cf13
(ftrace: don't try to __ftrace_replace_code on !FTRACE_FL_CONVERTED rec)

The patch is right except a mistake on the check for the FTRACE_FL_CONVERTED
flag. The code patching is aborted in case of successfully nopped sites.
What we want is the opposite: ignore the callsites that haven't been nopped.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
This commit is contained in:
Frederic Weisbecker 2009-03-16 22:41:00 +01:00 committed by Steven Rostedt
parent b478b782e1
commit 03303549b1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kernel/trace/ftrace.c
View file

@ -537,7 +537,7 @@ static void ftrace_replace_code(int enable)
*/ */
if (rec->flags & FTRACE_FL_FREE || if (rec->flags & FTRACE_FL_FREE ||
rec->flags & FTRACE_FL_FAILED || rec->flags & FTRACE_FL_FAILED ||
rec->flags & FTRACE_FL_CONVERTED) !(rec->flags & FTRACE_FL_CONVERTED))
continue; continue;
/* ignore updates to this record's mcount site */ /* ignore updates to this record's mcount site */