Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

softlockup: fix false positives on nohz if CPU is 100% idle for more than 60 seconds

Browse source 
Fix (probably theoretical only) rq->clock update bug:
in tick_nohz_update_jiffies() [which is called on all irq
entry on all cpus where the irq entry hits an idle cpu] we
call touch_softlockup_watchdog() before we update jiffies.
That works fine most of the time when idle timeouts are within
60 seconds. But when an idle timeout is beyond 60 seconds,
jiffies is updated with a jump of more than 60 seconds,
which causes a jump in cpu-clock of more than 60 seconds,
triggering a false positive.

Reported-by: David Miller <davem@davemloft.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Ingo Molnar 2008-05-12 15:43:53 +02:00
parent 1c4cd6dd1d
commit 02ff375590
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
kernel/time/tick-sched.c
View file

@ -133,8 +133,6 @@ void tick_nohz_update_jiffies(void)
if (!ts->tick_stopped) if (!ts->tick_stopped)
return; return;
touch_softlockup_watchdog();
cpu_clear(cpu, nohz_cpu_mask); cpu_clear(cpu, nohz_cpu_mask);
now = ktime_get(); now = ktime_get();
ts->idle_waketime = now; ts->idle_waketime = now;
@ -142,6 +140,8 @@ void tick_nohz_update_jiffies(void)
local_irq_save(flags); local_irq_save(flags);
tick_do_update_jiffies64(now); tick_do_update_jiffies64(now);
local_irq_restore(flags); local_irq_restore(flags);
touch_softlockup_watchdog();
} }
void tick_nohz_stop_idle(int cpu) void tick_nohz_stop_idle(int cpu)