2013-04-01 06:57:49 -06:00
|
|
|
/*
|
|
|
|
* ARM big.LITTLE Platforms CPUFreq support
|
|
|
|
*
|
|
|
|
* Copyright (C) 2013 ARM Ltd.
|
|
|
|
* Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
|
|
|
|
*
|
|
|
|
* Copyright (C) 2013 Linaro.
|
|
|
|
* Viresh Kumar <viresh.kumar@linaro.org>
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
|
|
* published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed "as is" WITHOUT ANY WARRANTY of any
|
|
|
|
* kind, whether express or implied; without even the implied warranty
|
|
|
|
* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
|
|
|
|
#include <linux/clk.h>
|
|
|
|
#include <linux/cpu.h>
|
|
|
|
#include <linux/cpufreq.h>
|
|
|
|
#include <linux/cpumask.h>
|
2015-11-17 05:06:23 -07:00
|
|
|
#include <linux/cpu_cooling.h>
|
2013-04-01 06:57:49 -06:00
|
|
|
#include <linux/export.h>
|
2014-08-08 00:56:30 -06:00
|
|
|
#include <linux/module.h>
|
2013-10-30 13:44:40 -06:00
|
|
|
#include <linux/mutex.h>
|
2013-04-01 06:57:49 -06:00
|
|
|
#include <linux/of_platform.h>
|
2013-09-19 15:03:52 -06:00
|
|
|
#include <linux/pm_opp.h>
|
2013-04-01 06:57:49 -06:00
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/topology.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
|
|
|
|
#include "arm_big_little.h"
|
|
|
|
|
|
|
|
/* Currently we support only two clusters */
|
2013-10-30 13:44:40 -06:00
|
|
|
#define A15_CLUSTER 0
|
|
|
|
#define A7_CLUSTER 1
|
2013-04-01 06:57:49 -06:00
|
|
|
#define MAX_CLUSTERS 2
|
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
#ifdef CONFIG_BL_SWITCHER
|
2015-05-13 06:35:52 -06:00
|
|
|
#include <asm/bL_switcher.h>
|
2013-10-30 13:44:41 -06:00
|
|
|
static bool bL_switching_enabled;
|
|
|
|
#define is_bL_switching_enabled() bL_switching_enabled
|
|
|
|
#define set_switching_enabled(x) (bL_switching_enabled = (x))
|
2013-10-30 13:44:40 -06:00
|
|
|
#else
|
|
|
|
#define is_bL_switching_enabled() false
|
2013-10-30 13:44:41 -06:00
|
|
|
#define set_switching_enabled(x) do { } while (0)
|
2015-05-13 06:35:52 -06:00
|
|
|
#define bL_switch_request(...) do { } while (0)
|
|
|
|
#define bL_switcher_put_enabled() do { } while (0)
|
|
|
|
#define bL_switcher_get_enabled() do { } while (0)
|
2013-10-30 13:44:40 -06:00
|
|
|
#endif
|
|
|
|
|
|
|
|
#define ACTUAL_FREQ(cluster, freq) ((cluster == A7_CLUSTER) ? freq << 1 : freq)
|
|
|
|
#define VIRT_FREQ(cluster, freq) ((cluster == A7_CLUSTER) ? freq >> 1 : freq)
|
|
|
|
|
2015-11-17 05:06:23 -07:00
|
|
|
static struct thermal_cooling_device *cdev[MAX_CLUSTERS];
|
2017-10-19 04:59:14 -06:00
|
|
|
static const struct cpufreq_arm_bL_ops *arm_bL_ops;
|
2013-04-01 06:57:49 -06:00
|
|
|
static struct clk *clk[MAX_CLUSTERS];
|
2013-10-30 13:44:40 -06:00
|
|
|
static struct cpufreq_frequency_table *freq_table[MAX_CLUSTERS + 1];
|
|
|
|
static atomic_t cluster_usage[MAX_CLUSTERS + 1];
|
|
|
|
|
|
|
|
static unsigned int clk_big_min; /* (Big) clock frequencies */
|
|
|
|
static unsigned int clk_little_max; /* Maximum clock frequency (Little) */
|
|
|
|
|
|
|
|
static DEFINE_PER_CPU(unsigned int, physical_cluster);
|
|
|
|
static DEFINE_PER_CPU(unsigned int, cpu_last_req_freq);
|
|
|
|
|
|
|
|
static struct mutex cluster_lock[MAX_CLUSTERS];
|
|
|
|
|
|
|
|
static inline int raw_cpu_to_cluster(int cpu)
|
|
|
|
{
|
|
|
|
return topology_physical_package_id(cpu);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int cpu_to_cluster(int cpu)
|
|
|
|
{
|
|
|
|
return is_bL_switching_enabled() ?
|
|
|
|
MAX_CLUSTERS : raw_cpu_to_cluster(cpu);
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int find_cluster_maxfreq(int cluster)
|
|
|
|
{
|
|
|
|
int j;
|
|
|
|
u32 max_freq = 0, cpu_freq;
|
|
|
|
|
|
|
|
for_each_online_cpu(j) {
|
|
|
|
cpu_freq = per_cpu(cpu_last_req_freq, j);
|
|
|
|
|
|
|
|
if ((cluster == per_cpu(physical_cluster, j)) &&
|
|
|
|
(max_freq < cpu_freq))
|
|
|
|
max_freq = cpu_freq;
|
|
|
|
}
|
|
|
|
|
|
|
|
pr_debug("%s: cluster: %d, max freq: %d\n", __func__, cluster,
|
|
|
|
max_freq);
|
|
|
|
|
|
|
|
return max_freq;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int clk_get_cpu_rate(unsigned int cpu)
|
|
|
|
{
|
|
|
|
u32 cur_cluster = per_cpu(physical_cluster, cpu);
|
|
|
|
u32 rate = clk_get_rate(clk[cur_cluster]) / 1000;
|
|
|
|
|
|
|
|
/* For switcher we use virtual A7 clock rates */
|
|
|
|
if (is_bL_switching_enabled())
|
|
|
|
rate = VIRT_FREQ(cur_cluster, rate);
|
|
|
|
|
|
|
|
pr_debug("%s: cpu: %d, cluster: %d, freq: %u\n", __func__, cpu,
|
|
|
|
cur_cluster, rate);
|
|
|
|
|
|
|
|
return rate;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int bL_cpufreq_get_rate(unsigned int cpu)
|
|
|
|
{
|
|
|
|
if (is_bL_switching_enabled()) {
|
|
|
|
pr_debug("%s: freq: %d\n", __func__, per_cpu(cpu_last_req_freq,
|
|
|
|
cpu));
|
|
|
|
|
|
|
|
return per_cpu(cpu_last_req_freq, cpu);
|
|
|
|
} else {
|
|
|
|
return clk_get_cpu_rate(cpu);
|
|
|
|
}
|
|
|
|
}
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
static unsigned int
|
|
|
|
bL_cpufreq_set_rate(u32 cpu, u32 old_cluster, u32 new_cluster, u32 rate)
|
2013-04-01 06:57:49 -06:00
|
|
|
{
|
2013-10-30 13:44:40 -06:00
|
|
|
u32 new_rate, prev_rate;
|
|
|
|
int ret;
|
|
|
|
bool bLs = is_bL_switching_enabled();
|
|
|
|
|
|
|
|
mutex_lock(&cluster_lock[new_cluster]);
|
|
|
|
|
|
|
|
if (bLs) {
|
|
|
|
prev_rate = per_cpu(cpu_last_req_freq, cpu);
|
|
|
|
per_cpu(cpu_last_req_freq, cpu) = rate;
|
|
|
|
per_cpu(physical_cluster, cpu) = new_cluster;
|
|
|
|
|
|
|
|
new_rate = find_cluster_maxfreq(new_cluster);
|
|
|
|
new_rate = ACTUAL_FREQ(new_cluster, new_rate);
|
|
|
|
} else {
|
|
|
|
new_rate = rate;
|
|
|
|
}
|
|
|
|
|
|
|
|
pr_debug("%s: cpu: %d, old cluster: %d, new cluster: %d, freq: %d\n",
|
|
|
|
__func__, cpu, old_cluster, new_cluster, new_rate);
|
|
|
|
|
|
|
|
ret = clk_set_rate(clk[new_cluster], new_rate * 1000);
|
2015-10-21 03:55:33 -06:00
|
|
|
if (!ret) {
|
|
|
|
/*
|
|
|
|
* FIXME: clk_set_rate hasn't returned an error here however it
|
|
|
|
* may be that clk_change_rate failed due to hardware or
|
|
|
|
* firmware issues and wasn't able to report that due to the
|
|
|
|
* current design of the clk core layer. To work around this
|
|
|
|
* problem we will read back the clock rate and check it is
|
|
|
|
* correct. This needs to be removed once clk core is fixed.
|
|
|
|
*/
|
|
|
|
if (clk_get_rate(clk[new_cluster]) != new_rate * 1000)
|
|
|
|
ret = -EIO;
|
|
|
|
}
|
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
if (WARN_ON(ret)) {
|
|
|
|
pr_err("clk_set_rate failed: %d, new cluster: %d\n", ret,
|
|
|
|
new_cluster);
|
|
|
|
if (bLs) {
|
|
|
|
per_cpu(cpu_last_req_freq, cpu) = prev_rate;
|
|
|
|
per_cpu(physical_cluster, cpu) = old_cluster;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&cluster_lock[new_cluster]);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&cluster_lock[new_cluster]);
|
|
|
|
|
|
|
|
/* Recalc freq for old cluster when switching clusters */
|
|
|
|
if (old_cluster != new_cluster) {
|
|
|
|
pr_debug("%s: cpu: %d, old cluster: %d, new cluster: %d\n",
|
|
|
|
__func__, cpu, old_cluster, new_cluster);
|
|
|
|
|
|
|
|
/* Switch cluster */
|
|
|
|
bL_switch_request(cpu, new_cluster);
|
|
|
|
|
|
|
|
mutex_lock(&cluster_lock[old_cluster]);
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
/* Set freq of old cluster if there are cpus left on it */
|
|
|
|
new_rate = find_cluster_maxfreq(old_cluster);
|
|
|
|
new_rate = ACTUAL_FREQ(old_cluster, new_rate);
|
|
|
|
|
|
|
|
if (new_rate) {
|
|
|
|
pr_debug("%s: Updating rate of old cluster: %d, to freq: %d\n",
|
|
|
|
__func__, old_cluster, new_rate);
|
|
|
|
|
|
|
|
if (clk_set_rate(clk[old_cluster], new_rate * 1000))
|
|
|
|
pr_err("%s: clk_set_rate failed: %d, old cluster: %d\n",
|
|
|
|
__func__, ret, old_cluster);
|
|
|
|
}
|
|
|
|
mutex_unlock(&cluster_lock[old_cluster]);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Set clock frequency */
|
|
|
|
static int bL_cpufreq_set_target(struct cpufreq_policy *policy,
|
2013-10-25 08:15:48 -06:00
|
|
|
unsigned int index)
|
2013-04-01 06:57:49 -06:00
|
|
|
{
|
2013-10-30 13:44:40 -06:00
|
|
|
u32 cpu = policy->cpu, cur_cluster, new_cluster, actual_cluster;
|
2013-08-14 08:08:24 -06:00
|
|
|
unsigned int freqs_new;
|
2017-09-26 10:41:08 -06:00
|
|
|
int ret;
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
cur_cluster = cpu_to_cluster(cpu);
|
|
|
|
new_cluster = actual_cluster = per_cpu(physical_cluster, cpu);
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-08-14 08:08:24 -06:00
|
|
|
freqs_new = freq_table[cur_cluster][index].frequency;
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
if (is_bL_switching_enabled()) {
|
|
|
|
if ((actual_cluster == A15_CLUSTER) &&
|
2013-08-14 08:08:24 -06:00
|
|
|
(freqs_new < clk_big_min)) {
|
2013-10-30 13:44:40 -06:00
|
|
|
new_cluster = A7_CLUSTER;
|
|
|
|
} else if ((actual_cluster == A7_CLUSTER) &&
|
2013-08-14 08:08:24 -06:00
|
|
|
(freqs_new > clk_little_max)) {
|
2013-10-30 13:44:40 -06:00
|
|
|
new_cluster = A15_CLUSTER;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-26 10:41:08 -06:00
|
|
|
ret = bL_cpufreq_set_rate(cpu, actual_cluster, new_cluster, freqs_new);
|
|
|
|
|
|
|
|
if (!ret) {
|
|
|
|
arch_set_freq_scale(policy->related_cpus, freqs_new,
|
|
|
|
policy->cpuinfo.max_freq);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
static inline u32 get_table_count(struct cpufreq_frequency_table *table)
|
|
|
|
{
|
|
|
|
int count;
|
|
|
|
|
|
|
|
for (count = 0; table[count].frequency != CPUFREQ_TABLE_END; count++)
|
|
|
|
;
|
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* get the minimum frequency in the cpufreq_frequency_table */
|
|
|
|
static inline u32 get_table_min(struct cpufreq_frequency_table *table)
|
|
|
|
{
|
2014-04-25 14:15:38 -06:00
|
|
|
struct cpufreq_frequency_table *pos;
|
2013-10-30 13:44:40 -06:00
|
|
|
uint32_t min_freq = ~0;
|
2014-04-25 14:15:38 -06:00
|
|
|
cpufreq_for_each_entry(pos, table)
|
|
|
|
if (pos->frequency < min_freq)
|
|
|
|
min_freq = pos->frequency;
|
2013-10-30 13:44:40 -06:00
|
|
|
return min_freq;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* get the maximum frequency in the cpufreq_frequency_table */
|
|
|
|
static inline u32 get_table_max(struct cpufreq_frequency_table *table)
|
|
|
|
{
|
2014-04-25 14:15:38 -06:00
|
|
|
struct cpufreq_frequency_table *pos;
|
2013-10-30 13:44:40 -06:00
|
|
|
uint32_t max_freq = 0;
|
2014-04-25 14:15:38 -06:00
|
|
|
cpufreq_for_each_entry(pos, table)
|
|
|
|
if (pos->frequency > max_freq)
|
|
|
|
max_freq = pos->frequency;
|
2013-10-30 13:44:40 -06:00
|
|
|
return max_freq;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int merge_cluster_tables(void)
|
|
|
|
{
|
|
|
|
int i, j, k = 0, count = 1;
|
|
|
|
struct cpufreq_frequency_table *table;
|
|
|
|
|
|
|
|
for (i = 0; i < MAX_CLUSTERS; i++)
|
|
|
|
count += get_table_count(freq_table[i]);
|
|
|
|
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 15:03:40 -06:00
|
|
|
table = kcalloc(count, sizeof(*table), GFP_KERNEL);
|
2013-10-30 13:44:40 -06:00
|
|
|
if (!table)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
freq_table[MAX_CLUSTERS] = table;
|
|
|
|
|
|
|
|
/* Add in reverse order to get freqs in increasing order */
|
|
|
|
for (i = MAX_CLUSTERS - 1; i >= 0; i--) {
|
|
|
|
for (j = 0; freq_table[i][j].frequency != CPUFREQ_TABLE_END;
|
|
|
|
j++) {
|
|
|
|
table[k].frequency = VIRT_FREQ(i,
|
|
|
|
freq_table[i][j].frequency);
|
|
|
|
pr_debug("%s: index: %d, freq: %d\n", __func__, k,
|
|
|
|
table[k].frequency);
|
|
|
|
k++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
table[k].driver_data = k;
|
|
|
|
table[k].frequency = CPUFREQ_TABLE_END;
|
|
|
|
|
|
|
|
pr_debug("%s: End, table: %p, count: %d\n", __func__, table, k);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
static void _put_cluster_clk_and_freq_table(struct device *cpu_dev,
|
|
|
|
const struct cpumask *cpumask)
|
2013-10-30 13:44:40 -06:00
|
|
|
{
|
|
|
|
u32 cluster = raw_cpu_to_cluster(cpu_dev->id);
|
|
|
|
|
|
|
|
if (!freq_table[cluster])
|
|
|
|
return;
|
|
|
|
|
|
|
|
clk_put(clk[cluster]);
|
|
|
|
dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table[cluster]);
|
2014-11-25 03:34:20 -07:00
|
|
|
if (arm_bL_ops->free_opp_table)
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
arm_bL_ops->free_opp_table(cpumask);
|
2013-10-30 13:44:40 -06:00
|
|
|
dev_dbg(cpu_dev, "%s: cluster: %d\n", __func__, cluster);
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
static void put_cluster_clk_and_freq_table(struct device *cpu_dev,
|
|
|
|
const struct cpumask *cpumask)
|
2013-04-01 06:57:49 -06:00
|
|
|
{
|
|
|
|
u32 cluster = cpu_to_cluster(cpu_dev->id);
|
2013-10-30 13:44:40 -06:00
|
|
|
int i;
|
|
|
|
|
|
|
|
if (atomic_dec_return(&cluster_usage[cluster]))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (cluster < MAX_CLUSTERS)
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
return _put_cluster_clk_and_freq_table(cpu_dev, cpumask);
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
for_each_present_cpu(i) {
|
|
|
|
struct device *cdev = get_cpu_device(i);
|
|
|
|
if (!cdev) {
|
|
|
|
pr_err("%s: failed to get cpu%d device\n", __func__, i);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
_put_cluster_clk_and_freq_table(cdev, cpumask);
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
2013-10-30 13:44:40 -06:00
|
|
|
|
|
|
|
/* free virtual table */
|
|
|
|
kfree(freq_table[cluster]);
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
static int _get_cluster_clk_and_freq_table(struct device *cpu_dev,
|
|
|
|
const struct cpumask *cpumask)
|
2013-04-01 06:57:49 -06:00
|
|
|
{
|
2013-10-30 13:44:40 -06:00
|
|
|
u32 cluster = raw_cpu_to_cluster(cpu_dev->id);
|
2013-04-01 06:57:49 -06:00
|
|
|
int ret;
|
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
if (freq_table[cluster])
|
2013-04-01 06:57:49 -06:00
|
|
|
return 0;
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
ret = arm_bL_ops->init_opp_table(cpumask);
|
2013-04-01 06:57:49 -06:00
|
|
|
if (ret) {
|
|
|
|
dev_err(cpu_dev, "%s: init_opp_table failed, cpu: %d, err: %d\n",
|
|
|
|
__func__, cpu_dev->id, ret);
|
2013-10-30 13:44:40 -06:00
|
|
|
goto out;
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
|
|
|
|
2013-09-19 15:03:50 -06:00
|
|
|
ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table[cluster]);
|
2013-04-01 06:57:49 -06:00
|
|
|
if (ret) {
|
|
|
|
dev_err(cpu_dev, "%s: failed to init cpufreq table, cpu: %d, err: %d\n",
|
|
|
|
__func__, cpu_dev->id, ret);
|
2014-11-25 03:34:20 -07:00
|
|
|
goto free_opp_table;
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
|
|
|
|
2015-04-27 03:51:06 -06:00
|
|
|
clk[cluster] = clk_get(cpu_dev, NULL);
|
2013-04-01 06:57:49 -06:00
|
|
|
if (!IS_ERR(clk[cluster])) {
|
|
|
|
dev_dbg(cpu_dev, "%s: clk: %p & freq table: %p, cluster: %d\n",
|
|
|
|
__func__, clk[cluster], freq_table[cluster],
|
|
|
|
cluster);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev_err(cpu_dev, "%s: Failed to get clk for cpu: %d, cluster: %d\n",
|
|
|
|
__func__, cpu_dev->id, cluster);
|
|
|
|
ret = PTR_ERR(clk[cluster]);
|
2013-09-19 15:03:50 -06:00
|
|
|
dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table[cluster]);
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2014-11-25 03:34:20 -07:00
|
|
|
free_opp_table:
|
|
|
|
if (arm_bL_ops->free_opp_table)
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
arm_bL_ops->free_opp_table(cpumask);
|
2013-10-30 13:44:40 -06:00
|
|
|
out:
|
2013-04-01 06:57:49 -06:00
|
|
|
dev_err(cpu_dev, "%s: Failed to get data for cluster: %d\n", __func__,
|
|
|
|
cluster);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
static int get_cluster_clk_and_freq_table(struct device *cpu_dev,
|
|
|
|
const struct cpumask *cpumask)
|
2013-10-30 13:44:40 -06:00
|
|
|
{
|
|
|
|
u32 cluster = cpu_to_cluster(cpu_dev->id);
|
|
|
|
int i, ret;
|
|
|
|
|
|
|
|
if (atomic_inc_return(&cluster_usage[cluster]) != 1)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (cluster < MAX_CLUSTERS) {
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
ret = _get_cluster_clk_and_freq_table(cpu_dev, cpumask);
|
2013-10-30 13:44:40 -06:00
|
|
|
if (ret)
|
|
|
|
atomic_dec(&cluster_usage[cluster]);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Get data for all clusters and fill virtual cluster with a merge of
|
|
|
|
* both
|
|
|
|
*/
|
|
|
|
for_each_present_cpu(i) {
|
|
|
|
struct device *cdev = get_cpu_device(i);
|
|
|
|
if (!cdev) {
|
|
|
|
pr_err("%s: failed to get cpu%d device\n", __func__, i);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
ret = _get_cluster_clk_and_freq_table(cdev, cpumask);
|
2013-10-30 13:44:40 -06:00
|
|
|
if (ret)
|
|
|
|
goto put_clusters;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = merge_cluster_tables();
|
|
|
|
if (ret)
|
|
|
|
goto put_clusters;
|
|
|
|
|
|
|
|
/* Assuming 2 cluster, set clk_big_min and clk_little_max */
|
|
|
|
clk_big_min = get_table_min(freq_table[0]);
|
|
|
|
clk_little_max = VIRT_FREQ(1, get_table_max(freq_table[1]));
|
|
|
|
|
|
|
|
pr_debug("%s: cluster: %d, clk_big_min: %d, clk_little_max: %d\n",
|
|
|
|
__func__, cluster, clk_big_min, clk_little_max);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
put_clusters:
|
|
|
|
for_each_present_cpu(i) {
|
|
|
|
struct device *cdev = get_cpu_device(i);
|
|
|
|
if (!cdev) {
|
|
|
|
pr_err("%s: failed to get cpu%d device\n", __func__, i);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
_put_cluster_clk_and_freq_table(cdev, cpumask);
|
2013-10-30 13:44:40 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
atomic_dec(&cluster_usage[cluster]);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2013-04-01 06:57:49 -06:00
|
|
|
/* Per-CPU initialization */
|
|
|
|
static int bL_cpufreq_init(struct cpufreq_policy *policy)
|
|
|
|
{
|
|
|
|
u32 cur_cluster = cpu_to_cluster(policy->cpu);
|
|
|
|
struct device *cpu_dev;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
cpu_dev = get_cpu_device(policy->cpu);
|
|
|
|
if (!cpu_dev) {
|
|
|
|
pr_err("%s: failed to get cpu%d device\n", __func__,
|
|
|
|
policy->cpu);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
if (cur_cluster < MAX_CLUSTERS) {
|
2014-03-14 00:40:55 -06:00
|
|
|
int cpu;
|
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
cpumask_copy(policy->cpus, topology_core_cpumask(policy->cpu));
|
|
|
|
|
2014-03-14 00:40:55 -06:00
|
|
|
for_each_cpu(cpu, policy->cpus)
|
|
|
|
per_cpu(physical_cluster, cpu) = cur_cluster;
|
2013-10-30 13:44:40 -06:00
|
|
|
} else {
|
|
|
|
/* Assumption: during init, we are always running on A15 */
|
|
|
|
per_cpu(physical_cluster, policy->cpu) = A15_CLUSTER;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
ret = get_cluster_clk_and_freq_table(cpu_dev, policy->cpus);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2018-02-25 22:08:47 -07:00
|
|
|
policy->freq_table = freq_table[cur_cluster];
|
2017-07-19 04:12:45 -06:00
|
|
|
policy->cpuinfo.transition_latency =
|
|
|
|
arm_bL_ops->get_transition_latency(cpu_dev);
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
if (is_bL_switching_enabled())
|
|
|
|
per_cpu(cpu_last_req_freq, policy->cpu) = clk_get_cpu_rate(policy->cpu);
|
2013-04-01 06:57:49 -06:00
|
|
|
|
2013-04-29 07:24:48 -06:00
|
|
|
dev_info(cpu_dev, "%s: CPU %d initialized\n", __func__, policy->cpu);
|
2013-04-01 06:57:49 -06:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bL_cpufreq_exit(struct cpufreq_policy *policy)
|
|
|
|
{
|
|
|
|
struct device *cpu_dev;
|
2015-11-17 05:06:23 -07:00
|
|
|
int cur_cluster = cpu_to_cluster(policy->cpu);
|
|
|
|
|
|
|
|
if (cur_cluster < MAX_CLUSTERS) {
|
|
|
|
cpufreq_cooling_unregister(cdev[cur_cluster]);
|
|
|
|
cdev[cur_cluster] = NULL;
|
|
|
|
}
|
2013-04-01 06:57:49 -06:00
|
|
|
|
|
|
|
cpu_dev = get_cpu_device(policy->cpu);
|
|
|
|
if (!cpu_dev) {
|
|
|
|
pr_err("%s: failed to get cpu%d device\n", __func__,
|
|
|
|
policy->cpu);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
cpufreq: arm_big_little: use generic OPP functions for {init, free}_opp_table
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2016-05-03 08:05:05 -06:00
|
|
|
put_cluster_clk_and_freq_table(cpu_dev, policy->related_cpus);
|
2013-04-01 06:57:49 -06:00
|
|
|
dev_dbg(cpu_dev, "%s: Exited, cpu: %d\n", __func__, policy->cpu);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-11-17 05:06:23 -07:00
|
|
|
static void bL_cpufreq_ready(struct cpufreq_policy *policy)
|
|
|
|
{
|
|
|
|
int cur_cluster = cpu_to_cluster(policy->cpu);
|
|
|
|
|
|
|
|
/* Do not register a cpu_cooling device if we are in IKS mode */
|
|
|
|
if (cur_cluster >= MAX_CLUSTERS)
|
|
|
|
return;
|
|
|
|
|
2017-12-04 22:32:45 -07:00
|
|
|
cdev[cur_cluster] = of_cpufreq_cooling_register(policy);
|
2015-11-17 05:06:23 -07:00
|
|
|
}
|
|
|
|
|
2013-04-01 06:57:49 -06:00
|
|
|
static struct cpufreq_driver bL_cpufreq_driver = {
|
|
|
|
.name = "arm-big-little",
|
2013-10-02 02:43:18 -06:00
|
|
|
.flags = CPUFREQ_STICKY |
|
2013-12-02 22:50:45 -07:00
|
|
|
CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
|
|
|
|
CPUFREQ_NEED_INITIAL_FREQ_CHECK,
|
2013-10-03 08:57:57 -06:00
|
|
|
.verify = cpufreq_generic_frequency_table_verify,
|
2013-10-25 08:15:48 -06:00
|
|
|
.target_index = bL_cpufreq_set_target,
|
2013-10-30 13:44:40 -06:00
|
|
|
.get = bL_cpufreq_get_rate,
|
2013-04-01 06:57:49 -06:00
|
|
|
.init = bL_cpufreq_init,
|
|
|
|
.exit = bL_cpufreq_exit,
|
2015-11-17 05:06:23 -07:00
|
|
|
.ready = bL_cpufreq_ready,
|
2013-10-03 08:57:57 -06:00
|
|
|
.attr = cpufreq_generic_attr,
|
2013-04-01 06:57:49 -06:00
|
|
|
};
|
|
|
|
|
2015-05-13 06:35:52 -06:00
|
|
|
#ifdef CONFIG_BL_SWITCHER
|
2013-10-30 13:44:41 -06:00
|
|
|
static int bL_cpufreq_switcher_notifier(struct notifier_block *nfb,
|
|
|
|
unsigned long action, void *_arg)
|
|
|
|
{
|
|
|
|
pr_debug("%s: action: %ld\n", __func__, action);
|
|
|
|
|
|
|
|
switch (action) {
|
|
|
|
case BL_NOTIFY_PRE_ENABLE:
|
|
|
|
case BL_NOTIFY_PRE_DISABLE:
|
|
|
|
cpufreq_unregister_driver(&bL_cpufreq_driver);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case BL_NOTIFY_POST_ENABLE:
|
|
|
|
set_switching_enabled(true);
|
|
|
|
cpufreq_register_driver(&bL_cpufreq_driver);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case BL_NOTIFY_POST_DISABLE:
|
|
|
|
set_switching_enabled(false);
|
|
|
|
cpufreq_register_driver(&bL_cpufreq_driver);
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NOTIFY_OK;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct notifier_block bL_switcher_notifier = {
|
|
|
|
.notifier_call = bL_cpufreq_switcher_notifier,
|
|
|
|
};
|
|
|
|
|
2015-05-13 06:35:52 -06:00
|
|
|
static int __bLs_register_notifier(void)
|
|
|
|
{
|
|
|
|
return bL_switcher_register_notifier(&bL_switcher_notifier);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __bLs_unregister_notifier(void)
|
|
|
|
{
|
|
|
|
return bL_switcher_unregister_notifier(&bL_switcher_notifier);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static int __bLs_register_notifier(void) { return 0; }
|
|
|
|
static int __bLs_unregister_notifier(void) { return 0; }
|
|
|
|
#endif
|
|
|
|
|
2017-10-19 04:59:14 -06:00
|
|
|
int bL_cpufreq_register(const struct cpufreq_arm_bL_ops *ops)
|
2013-04-01 06:57:49 -06:00
|
|
|
{
|
2013-10-30 13:44:40 -06:00
|
|
|
int ret, i;
|
2013-04-01 06:57:49 -06:00
|
|
|
|
|
|
|
if (arm_bL_ops) {
|
|
|
|
pr_debug("%s: Already registered: %s, exiting\n", __func__,
|
|
|
|
arm_bL_ops->name);
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
2017-07-19 04:12:45 -06:00
|
|
|
if (!ops || !strlen(ops->name) || !ops->init_opp_table ||
|
|
|
|
!ops->get_transition_latency) {
|
2013-04-01 06:57:49 -06:00
|
|
|
pr_err("%s: Invalid arm_bL_ops, exiting\n", __func__);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
arm_bL_ops = ops;
|
|
|
|
|
2015-05-13 06:35:52 -06:00
|
|
|
set_switching_enabled(bL_switcher_get_enabled());
|
2013-10-30 13:44:41 -06:00
|
|
|
|
2013-10-30 13:44:40 -06:00
|
|
|
for (i = 0; i < MAX_CLUSTERS; i++)
|
|
|
|
mutex_init(&cluster_lock[i]);
|
|
|
|
|
2013-04-01 06:57:49 -06:00
|
|
|
ret = cpufreq_register_driver(&bL_cpufreq_driver);
|
|
|
|
if (ret) {
|
|
|
|
pr_info("%s: Failed registering platform driver: %s, err: %d\n",
|
|
|
|
__func__, ops->name, ret);
|
|
|
|
arm_bL_ops = NULL;
|
|
|
|
} else {
|
2015-05-13 06:35:52 -06:00
|
|
|
ret = __bLs_register_notifier();
|
2013-10-30 13:44:41 -06:00
|
|
|
if (ret) {
|
|
|
|
cpufreq_unregister_driver(&bL_cpufreq_driver);
|
|
|
|
arm_bL_ops = NULL;
|
|
|
|
} else {
|
|
|
|
pr_info("%s: Registered platform driver: %s\n",
|
|
|
|
__func__, ops->name);
|
|
|
|
}
|
2013-04-01 06:57:49 -06:00
|
|
|
}
|
|
|
|
|
2013-10-30 13:44:41 -06:00
|
|
|
bL_switcher_put_enabled();
|
2013-04-01 06:57:49 -06:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(bL_cpufreq_register);
|
|
|
|
|
2017-10-19 04:59:14 -06:00
|
|
|
void bL_cpufreq_unregister(const struct cpufreq_arm_bL_ops *ops)
|
2013-04-01 06:57:49 -06:00
|
|
|
{
|
|
|
|
if (arm_bL_ops != ops) {
|
|
|
|
pr_err("%s: Registered with: %s, can't unregister, exiting\n",
|
|
|
|
__func__, arm_bL_ops->name);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-10-30 13:44:41 -06:00
|
|
|
bL_switcher_get_enabled();
|
2015-05-13 06:35:52 -06:00
|
|
|
__bLs_unregister_notifier();
|
2013-04-01 06:57:49 -06:00
|
|
|
cpufreq_unregister_driver(&bL_cpufreq_driver);
|
2013-10-30 13:44:41 -06:00
|
|
|
bL_switcher_put_enabled();
|
2013-04-01 06:57:49 -06:00
|
|
|
pr_info("%s: Un-registered platform driver: %s\n", __func__,
|
|
|
|
arm_bL_ops->name);
|
|
|
|
arm_bL_ops = NULL;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(bL_cpufreq_unregister);
|
2014-08-08 00:56:30 -06:00
|
|
|
|
|
|
|
MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>");
|
|
|
|
MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver");
|
|
|
|
MODULE_LICENSE("GPL v2");
|