2008-07-28 10:44:22 -06:00
|
|
|
/*
|
|
|
|
* AMD CPU Microcode Update Driver for Linux
|
2011-12-02 10:09:23 -07:00
|
|
|
* Copyright (C) 2008-2011 Advanced Micro Devices Inc.
|
2008-07-28 10:44:22 -06:00
|
|
|
*
|
|
|
|
* Author: Peter Oruba <peter.oruba@amd.com>
|
|
|
|
*
|
|
|
|
* Based on work by:
|
|
|
|
* Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
|
|
|
|
*
|
2011-12-02 10:09:23 -07:00
|
|
|
* Maintainers:
|
|
|
|
* Andreas Herrmann <andreas.herrmann3@amd.com>
|
|
|
|
* Borislav Petkov <borislav.petkov@amd.com>
|
|
|
|
*
|
|
|
|
* This driver allows to upgrade microcode on F10h AMD
|
|
|
|
* CPUs and later.
|
2008-07-28 10:44:22 -06:00
|
|
|
*
|
2008-12-16 11:08:53 -07:00
|
|
|
* Licensed under the terms of the GNU General Public
|
2008-07-28 10:44:22 -06:00
|
|
|
* License version 2. See file COPYING for details.
|
2009-03-11 04:19:46 -06:00
|
|
|
*/
|
2009-12-08 23:30:50 -07:00
|
|
|
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
|
2009-03-11 04:19:46 -06:00
|
|
|
#include <linux/firmware.h>
|
|
|
|
#include <linux/pci_ids.h>
|
|
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <linux/vmalloc.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
2008-07-28 10:44:22 -06:00
|
|
|
#include <linux/pci.h>
|
|
|
|
|
|
|
|
#include <asm/microcode.h>
|
2009-03-11 04:19:46 -06:00
|
|
|
#include <asm/processor.h>
|
|
|
|
#include <asm/msr.h>
|
2008-07-28 10:44:22 -06:00
|
|
|
|
|
|
|
MODULE_DESCRIPTION("AMD Microcode Update Driver");
|
2008-10-17 07:30:38 -06:00
|
|
|
MODULE_AUTHOR("Peter Oruba");
|
2008-07-29 02:07:36 -06:00
|
|
|
MODULE_LICENSE("GPL v2");
|
2008-07-28 10:44:22 -06:00
|
|
|
|
|
|
|
#define UCODE_MAGIC 0x00414d44
|
|
|
|
#define UCODE_EQUIV_CPU_TABLE_TYPE 0x00000000
|
|
|
|
#define UCODE_UCODE_TYPE 0x00000001
|
|
|
|
|
2008-09-23 04:08:44 -06:00
|
|
|
struct equiv_cpu_entry {
|
2008-12-16 11:21:30 -07:00
|
|
|
u32 installed_cpu;
|
|
|
|
u32 fixed_errata_mask;
|
|
|
|
u32 fixed_errata_compare;
|
|
|
|
u16 equiv_cpu;
|
|
|
|
u16 res;
|
|
|
|
} __attribute__((packed));
|
2008-09-23 04:08:44 -06:00
|
|
|
|
|
|
|
struct microcode_header_amd {
|
2008-12-16 11:21:30 -07:00
|
|
|
u32 data_code;
|
|
|
|
u32 patch_id;
|
|
|
|
u16 mc_patch_data_id;
|
|
|
|
u8 mc_patch_data_len;
|
|
|
|
u8 init_flag;
|
|
|
|
u32 mc_patch_data_checksum;
|
|
|
|
u32 nb_dev_id;
|
|
|
|
u32 sb_dev_id;
|
|
|
|
u16 processor_rev_id;
|
|
|
|
u8 nb_rev_id;
|
|
|
|
u8 sb_rev_id;
|
|
|
|
u8 bios_api_rev;
|
|
|
|
u8 reserved1[3];
|
|
|
|
u32 match_reg[8];
|
|
|
|
} __attribute__((packed));
|
2008-09-23 04:08:44 -06:00
|
|
|
|
|
|
|
struct microcode_amd {
|
2009-03-11 04:19:46 -06:00
|
|
|
struct microcode_header_amd hdr;
|
|
|
|
unsigned int mpb[0];
|
2008-09-23 04:08:44 -06:00
|
|
|
};
|
|
|
|
|
2011-06-15 07:34:57 -06:00
|
|
|
#define SECTION_HDR_SIZE 8
|
|
|
|
#define CONTAINER_HDR_SZ 12
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2008-09-11 15:27:52 -06:00
|
|
|
static struct equiv_cpu_entry *equiv_cpu_table;
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2011-12-02 09:16:55 -07:00
|
|
|
/* page-sized ucode patch buffer */
|
|
|
|
void *patch;
|
|
|
|
|
2008-08-19 16:22:26 -06:00
|
|
|
static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
|
2008-07-28 10:44:22 -06:00
|
|
|
{
|
2010-01-22 13:34:56 -07:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2011-10-17 08:34:36 -06:00
|
|
|
csig->rev = c->microcode;
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_info("CPU%d: patch_level=0x%08x\n", cpu, csig->rev);
|
|
|
|
|
2008-08-19 16:22:26 -06:00
|
|
|
return 0;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
static unsigned int verify_ucode_size(int cpu, u32 patch_size,
|
|
|
|
unsigned int size)
|
2008-07-28 10:44:22 -06:00
|
|
|
{
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
|
|
|
u32 max_size;
|
|
|
|
|
|
|
|
#define F1XH_MPB_MAX_SIZE 2048
|
|
|
|
#define F14H_MPB_MAX_SIZE 1824
|
|
|
|
#define F15H_MPB_MAX_SIZE 4096
|
|
|
|
|
|
|
|
switch (c->x86) {
|
|
|
|
case 0x14:
|
|
|
|
max_size = F14H_MPB_MAX_SIZE;
|
|
|
|
break;
|
|
|
|
case 0x15:
|
|
|
|
max_size = F15H_MPB_MAX_SIZE;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
max_size = F1XH_MPB_MAX_SIZE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (patch_size > min_t(u32, size, max_size)) {
|
|
|
|
pr_err("patch size mismatch\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return patch_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
static u16 find_equiv_id(void)
|
|
|
|
{
|
|
|
|
unsigned int current_cpu_id, i = 0;
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2008-09-11 15:27:52 -06:00
|
|
|
BUG_ON(equiv_cpu_table == NULL);
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
|
2008-07-28 10:44:22 -06:00
|
|
|
current_cpu_id = cpuid_eax(0x00000001);
|
|
|
|
|
|
|
|
while (equiv_cpu_table[i].installed_cpu != 0) {
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
if (current_cpu_id == equiv_cpu_table[i].installed_cpu)
|
|
|
|
return equiv_cpu_table[i].equiv_cpu;
|
|
|
|
|
2008-07-28 10:44:22 -06:00
|
|
|
i++;
|
|
|
|
}
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
return 0;
|
|
|
|
}
|
2008-07-28 10:44:22 -06:00
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
/*
|
|
|
|
* we signal a good patch is found by returning its size > 0
|
|
|
|
*/
|
|
|
|
static int get_matching_microcode(int cpu, const u8 *ucode_ptr,
|
|
|
|
unsigned int leftover_size, int rev,
|
|
|
|
unsigned int *current_size)
|
|
|
|
{
|
|
|
|
struct microcode_header_amd *mc_hdr;
|
|
|
|
unsigned int actual_size;
|
|
|
|
u16 equiv_cpu_id;
|
|
|
|
|
|
|
|
/* size of the current patch we're staring at */
|
|
|
|
*current_size = *(u32 *)(ucode_ptr + 4) + SECTION_HDR_SIZE;
|
|
|
|
|
|
|
|
equiv_cpu_id = find_equiv_id();
|
2009-11-10 04:08:25 -07:00
|
|
|
if (!equiv_cpu_id)
|
2008-07-28 10:44:22 -06:00
|
|
|
return 0;
|
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
/*
|
|
|
|
* let's look at the patch header itself now
|
|
|
|
*/
|
|
|
|
mc_hdr = (struct microcode_header_amd *)(ucode_ptr + SECTION_HDR_SIZE);
|
|
|
|
|
2010-12-31 08:57:48 -07:00
|
|
|
if (mc_hdr->processor_rev_id != equiv_cpu_id)
|
2008-07-28 10:44:22 -06:00
|
|
|
return 0;
|
|
|
|
|
2008-12-16 11:20:21 -07:00
|
|
|
/* ucode might be chipset specific -- currently we don't support this */
|
2010-12-31 08:57:48 -07:00
|
|
|
if (mc_hdr->nb_dev_id || mc_hdr->sb_dev_id) {
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_err("CPU%d: chipset specific code not yet supported\n",
|
2009-12-08 23:30:50 -07:00
|
|
|
cpu);
|
2008-12-16 11:20:21 -07:00
|
|
|
return 0;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2010-12-31 08:57:48 -07:00
|
|
|
if (mc_hdr->patch_id <= rev)
|
2008-07-28 10:44:22 -06:00
|
|
|
return 0;
|
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
/*
|
|
|
|
* now that the header looks sane, verify its size
|
|
|
|
*/
|
|
|
|
actual_size = verify_ucode_size(cpu, *current_size, leftover_size);
|
|
|
|
if (!actual_size)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* clear the patch buffer */
|
|
|
|
memset(patch, 0, PAGE_SIZE);
|
|
|
|
|
|
|
|
/* all looks ok, get the binary patch */
|
|
|
|
get_ucode_data(patch, ucode_ptr + SECTION_HDR_SIZE, actual_size);
|
|
|
|
|
|
|
|
return actual_size;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2009-05-11 15:48:27 -06:00
|
|
|
static int apply_microcode_amd(int cpu)
|
2008-07-28 10:44:22 -06:00
|
|
|
{
|
2008-12-16 11:16:34 -07:00
|
|
|
u32 rev, dummy;
|
2008-07-28 10:44:22 -06:00
|
|
|
int cpu_num = raw_smp_processor_id();
|
|
|
|
struct ucode_cpu_info *uci = ucode_cpu_info + cpu_num;
|
2008-09-23 04:08:44 -06:00
|
|
|
struct microcode_amd *mc_amd = uci->mc;
|
2011-10-17 08:34:36 -06:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
2008-07-28 10:44:22 -06:00
|
|
|
|
|
|
|
/* We should bind the task to the CPU */
|
|
|
|
BUG_ON(cpu_num != cpu);
|
|
|
|
|
2008-09-23 04:08:44 -06:00
|
|
|
if (mc_amd == NULL)
|
2009-05-11 15:48:27 -06:00
|
|
|
return 0;
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2008-12-18 17:36:14 -07:00
|
|
|
wrmsrl(MSR_AMD64_PATCH_LOADER, (u64)(long)&mc_amd->hdr.data_code);
|
2008-07-28 10:44:22 -06:00
|
|
|
/* get patch id after patching */
|
2008-12-16 11:16:34 -07:00
|
|
|
rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);
|
2008-07-28 10:44:22 -06:00
|
|
|
|
|
|
|
/* check current patch id and patch's id for match */
|
2008-09-23 04:08:44 -06:00
|
|
|
if (rev != mc_amd->hdr.patch_id) {
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_err("CPU%d: update failed for patch_level=0x%08x\n",
|
2009-12-08 23:30:50 -07:00
|
|
|
cpu, mc_amd->hdr.patch_id);
|
2009-05-11 15:48:27 -06:00
|
|
|
return -1;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_info("CPU%d: new patch_level=0x%08x\n", cpu, rev);
|
2008-08-19 16:22:26 -06:00
|
|
|
uci->cpu_sig.rev = rev;
|
2011-10-17 08:34:36 -06:00
|
|
|
c->microcode = rev;
|
2009-05-11 15:48:27 -06:00
|
|
|
|
|
|
|
return 0;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2008-12-16 11:14:05 -07:00
|
|
|
static int install_equiv_cpu_table(const u8 *buf)
|
2008-07-28 10:44:22 -06:00
|
|
|
{
|
2010-12-30 14:10:12 -07:00
|
|
|
unsigned int *ibuf = (unsigned int *)buf;
|
|
|
|
unsigned int type = ibuf[1];
|
|
|
|
unsigned int size = ibuf[2];
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2010-12-30 14:10:12 -07:00
|
|
|
if (type != UCODE_EQUIV_CPU_TABLE_TYPE || !size) {
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_err("empty section/"
|
|
|
|
"invalid type field in container file section header\n");
|
2010-12-30 14:10:12 -07:00
|
|
|
return -EINVAL;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2010-11-08 16:08:11 -07:00
|
|
|
equiv_cpu_table = vmalloc(size);
|
2008-07-28 10:44:22 -06:00
|
|
|
if (!equiv_cpu_table) {
|
2009-12-08 23:30:50 -07:00
|
|
|
pr_err("failed to allocate equivalent CPU table\n");
|
2010-12-30 14:10:12 -07:00
|
|
|
return -ENOMEM;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2011-06-15 07:34:57 -06:00
|
|
|
get_ucode_data(equiv_cpu_table, buf + CONTAINER_HDR_SZ, size);
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2011-06-15 07:34:57 -06:00
|
|
|
/* add header length */
|
|
|
|
return size + CONTAINER_HDR_SZ;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
2008-09-11 15:27:52 -06:00
|
|
|
static void free_equiv_cpu_table(void)
|
2008-07-28 10:44:22 -06:00
|
|
|
{
|
2009-06-07 08:30:36 -06:00
|
|
|
vfree(equiv_cpu_table);
|
|
|
|
equiv_cpu_table = NULL;
|
2008-09-11 15:27:52 -06:00
|
|
|
}
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2009-05-11 15:48:27 -06:00
|
|
|
static enum ucode_state
|
|
|
|
generic_load_microcode(int cpu, const u8 *data, size_t size)
|
2008-09-11 15:27:52 -06:00
|
|
|
{
|
|
|
|
struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
|
2010-12-31 08:57:48 -07:00
|
|
|
struct microcode_header_amd *mc_hdr = NULL;
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
unsigned int mc_size, leftover, current_size = 0;
|
2011-02-18 02:17:16 -07:00
|
|
|
int offset;
|
2008-12-16 11:13:00 -07:00
|
|
|
const u8 *ucode_ptr = data;
|
|
|
|
void *new_mc = NULL;
|
2011-01-05 10:13:19 -07:00
|
|
|
unsigned int new_rev = uci->cpu_sig.rev;
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
enum ucode_state state = UCODE_ERROR;
|
2008-07-28 10:44:22 -06:00
|
|
|
|
2008-12-16 11:14:05 -07:00
|
|
|
offset = install_equiv_cpu_table(ucode_ptr);
|
2010-12-30 14:10:12 -07:00
|
|
|
if (offset < 0) {
|
2009-12-08 23:30:50 -07:00
|
|
|
pr_err("failed to create equivalent cpu table\n");
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
goto out;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
2008-09-11 15:27:52 -06:00
|
|
|
ucode_ptr += offset;
|
|
|
|
leftover = size - offset;
|
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
if (*(u32 *)ucode_ptr != UCODE_UCODE_TYPE) {
|
|
|
|
pr_err("invalid type field in container file section header\n");
|
|
|
|
goto free_table;
|
|
|
|
}
|
2008-09-11 15:27:52 -06:00
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
while (leftover) {
|
|
|
|
mc_size = get_matching_microcode(cpu, ucode_ptr, leftover,
|
|
|
|
new_rev, ¤t_size);
|
|
|
|
if (mc_size) {
|
|
|
|
mc_hdr = patch;
|
|
|
|
new_mc = patch;
|
2010-12-31 08:57:48 -07:00
|
|
|
new_rev = mc_hdr->patch_id;
|
2011-12-07 09:26:56 -07:00
|
|
|
goto out_ok;
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
}
|
2011-12-07 09:26:56 -07:00
|
|
|
|
|
|
|
ucode_ptr += current_size;
|
|
|
|
leftover -= current_size;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
2008-09-11 15:27:52 -06:00
|
|
|
|
2010-12-31 08:57:48 -07:00
|
|
|
if (!new_mc) {
|
2009-05-11 15:48:27 -06:00
|
|
|
state = UCODE_NFOUND;
|
2010-12-31 08:57:48 -07:00
|
|
|
goto free_table;
|
|
|
|
}
|
|
|
|
|
2011-12-07 09:26:56 -07:00
|
|
|
out_ok:
|
|
|
|
uci->mc = new_mc;
|
|
|
|
state = UCODE_OK;
|
|
|
|
pr_debug("CPU%d update ucode (0x%08x -> 0x%08x)\n",
|
|
|
|
cpu, uci->cpu_sig.rev, new_rev);
|
2008-09-11 15:27:52 -06:00
|
|
|
|
2010-12-31 08:57:48 -07:00
|
|
|
free_table:
|
2008-09-11 15:27:52 -06:00
|
|
|
free_equiv_cpu_table();
|
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 10:02:17 -07:00
|
|
|
out:
|
2009-05-11 15:48:27 -06:00
|
|
|
return state;
|
2008-09-11 15:27:52 -06:00
|
|
|
}
|
|
|
|
|
2012-01-20 09:44:12 -07:00
|
|
|
/*
|
|
|
|
* AMD microcode firmware naming convention, up to family 15h they are in
|
|
|
|
* the legacy file:
|
|
|
|
*
|
|
|
|
* amd-ucode/microcode_amd.bin
|
|
|
|
*
|
|
|
|
* This legacy file is always smaller than 2K in size.
|
|
|
|
*
|
|
|
|
* Starting at family 15h they are in family specific firmware files:
|
|
|
|
*
|
|
|
|
* amd-ucode/microcode_amd_fam15h.bin
|
|
|
|
* amd-ucode/microcode_amd_fam16h.bin
|
|
|
|
* ...
|
|
|
|
*
|
|
|
|
* These might be larger than 2K.
|
|
|
|
*/
|
2010-12-30 13:06:01 -07:00
|
|
|
static enum ucode_state request_microcode_amd(int cpu, struct device *device)
|
2008-09-11 15:27:52 -06:00
|
|
|
{
|
2012-01-20 09:44:12 -07:00
|
|
|
char fw_name[36] = "amd-ucode/microcode_amd.bin";
|
2010-12-30 13:06:01 -07:00
|
|
|
const struct firmware *fw;
|
|
|
|
enum ucode_state ret = UCODE_NFOUND;
|
2012-01-20 09:44:12 -07:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
|
|
|
|
|
|
|
if (c->x86 >= 0x15)
|
|
|
|
snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
|
2008-09-11 15:27:52 -06:00
|
|
|
|
2012-01-20 09:44:12 -07:00
|
|
|
if (request_firmware(&fw, (const char *)fw_name, device)) {
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_err("failed to load file %s\n", fw_name);
|
2010-12-30 13:06:01 -07:00
|
|
|
goto out;
|
2010-01-22 13:34:56 -07:00
|
|
|
}
|
2008-09-11 15:27:52 -06:00
|
|
|
|
2010-12-30 13:06:01 -07:00
|
|
|
ret = UCODE_ERROR;
|
|
|
|
if (*(u32 *)fw->data != UCODE_MAGIC) {
|
2011-01-05 10:13:19 -07:00
|
|
|
pr_err("invalid magic value (0x%08x)\n", *(u32 *)fw->data);
|
2010-12-30 13:06:01 -07:00
|
|
|
goto fw_release;
|
2009-10-29 07:45:52 -06:00
|
|
|
}
|
|
|
|
|
2010-12-30 13:06:01 -07:00
|
|
|
ret = generic_load_microcode(cpu, fw->data, fw->size);
|
2008-09-11 15:27:52 -06:00
|
|
|
|
2010-12-30 13:06:01 -07:00
|
|
|
fw_release:
|
|
|
|
release_firmware(fw);
|
2010-01-22 13:34:56 -07:00
|
|
|
|
2010-12-30 13:06:01 -07:00
|
|
|
out:
|
2008-09-11 15:27:52 -06:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2009-05-11 15:48:27 -06:00
|
|
|
static enum ucode_state
|
|
|
|
request_microcode_user(int cpu, const void __user *buf, size_t size)
|
2008-09-11 15:27:52 -06:00
|
|
|
{
|
2009-05-11 15:48:27 -06:00
|
|
|
return UCODE_ERROR;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static void microcode_fini_cpu_amd(int cpu)
|
|
|
|
{
|
|
|
|
struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
|
|
|
|
|
2008-09-23 04:08:44 -06:00
|
|
|
uci->mc = NULL;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct microcode_ops microcode_amd_ops = {
|
2008-09-11 15:27:52 -06:00
|
|
|
.request_microcode_user = request_microcode_user,
|
2010-12-30 13:06:01 -07:00
|
|
|
.request_microcode_fw = request_microcode_amd,
|
2008-07-28 10:44:22 -06:00
|
|
|
.collect_cpu_info = collect_cpu_info_amd,
|
|
|
|
.apply_microcode = apply_microcode_amd,
|
|
|
|
.microcode_fini_cpu = microcode_fini_cpu_amd,
|
|
|
|
};
|
|
|
|
|
2008-09-23 04:08:44 -06:00
|
|
|
struct microcode_ops * __init init_amd_microcode(void)
|
2008-07-28 10:44:22 -06:00
|
|
|
{
|
2012-04-12 08:51:57 -06:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(0);
|
|
|
|
|
|
|
|
if (c->x86_vendor != X86_VENDOR_AMD || c->x86 < 0x10) {
|
|
|
|
pr_warning("AMD CPU family 0x%x not supported\n", c->x86);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2011-12-02 09:16:55 -07:00
|
|
|
patch = (void *)get_zeroed_page(GFP_KERNEL);
|
|
|
|
if (!patch)
|
|
|
|
return NULL;
|
|
|
|
|
2008-09-23 04:08:44 -06:00
|
|
|
return µcode_amd_ops;
|
2008-07-28 10:44:22 -06:00
|
|
|
}
|
2011-12-02 08:50:04 -07:00
|
|
|
|
|
|
|
void __exit exit_amd_microcode(void)
|
|
|
|
{
|
2011-12-02 09:16:55 -07:00
|
|
|
free_page((unsigned long)patch);
|
2011-12-02 08:50:04 -07:00
|
|
|
}
|