Techwizz/EQ2EMu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Crash fix on bad quest design

Browse source 
A quest lacking Reload and CurrentStep functions properly working can crash server, this will prevent that
This commit is contained in:
Image 2021-08-28 09:02:10 -04:00
parent 9a4829a27d
commit 3f3c3f3266
1 changed files with 5 additions and 2 deletions

7
EQ2/source/WorldServer/client.cpp
View file

@ -234,7 +234,7 @@ Client::~Client() {
void Client::RemoveClientFromZone() {
if(player && player->GetZone())
player->GetZone()->GetSpellProcess()->RemoveSpellTimersFromSpawn(player, true);
if (current_zone && player) {
if (player->GetGroupMemberInfo())
{
@ -5525,8 +5525,11 @@ void Client::SetPlayerQuest(Quest* quest, map<int32, int32>* progress) {
lua_interface->CallQuestFunction(quest, "Reload", player, step->GetStepID());
}
}
if (lua_interface)
if (lua_interface && step)
lua_interface->CallQuestFunction(quest, "CurrentStep", player, step->GetStepID());
else if(!step) {
LogWrite(QUEST__ERROR, 0, "Client", "Missing step for quest %s (ID %u), cannot CallQuestFunction for CurrentStep", quest->GetName(), quest->GetQuestID());
}
}
void Client::AddPlayerQuest(Quest* quest, bool call_accepted, bool send_packets) {